Complete Phase 4: security hardening, player/playlist/admin UI, docs

Security:
- New internal/netguard package: podcast feed/enclosure fetching now
  refuses to dial non-public IPs (loopback/RFC1918/link-local/cloud
  metadata/CGNAT), validated per-connection including across redirects,
  closing an SSRF gap where a malicious or compromised feed URL could
  probe the server's internal network. Configurable via
  VIBESONIC_PODCASTS_ALLOW_PRIVATE_NETWORKS for intentional LAN feeds.
- Podcast episode downloads capped at 4GB (was unbounded, disk-exhaustion risk)
- Cover art decoding now rejects images above a 40-megapixel budget
  before full decode (decompression-bomb guard)
- HTTP server sets ReadHeaderTimeout (slowloris hardening)
- Admin folder-scan redirect now validated as same-site instead of
  trusting the raw Referer header (open-redirect fix)
- Legacy Subsonic token/salt auth now uses a constant-time comparison

Web UI completion:
- Persistent player: shuffle and repeat (off/all/one) controls, wired
  into queue advance/prev logic and persisted like other player state
- Admin user-permissions form: adminRole toggle (with a guard against
  demoting the last remaining admin) and per-user music-folder access
  checkboxes, backed by existing schema/enforcement that was previously
  unreachable from the UI
- Playlist M3U8 import/export

Docs: added docs/client-compatibility.md (honest tracking template —
no client testing has been performed), docs/deployment.md,
docs/security.md, docs/backup.md; refreshed README and cross-links;
added a footnote in docs/subsonic-compatibility.md distinguishing
spec-standard from VibeSonic-original OpenSubsonic extensions.

Also added Go fuzz tests for the external-auth CIDR/IP parser and the
LRC lyrics parser.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014r98AtcBbevpscWLsfwVvv
This commit is contained in:
2026-08-23 09:18:17 -05:00
co-authored by Claude Sonnet 5
parent 933ed31550
commit 789bf91eed
36 changed files with 1722 additions and 96 deletions
+85
View File
@@ -0,0 +1,85 @@
package netguard
import (
"context"
"net"
"net/http"
"net/http/httptest"
"testing"
"time"
)
func TestIsPublicIP(t *testing.T) {
cases := map[string]bool{
"8.8.8.8": true,
"1.1.1.1": true,
"127.0.0.1": false,
"10.0.0.1": false,
"172.16.0.1": false,
"192.168.1.1": false,
"169.254.169.254": false, // cloud metadata
"100.64.0.1": false, // CGNAT
"0.0.0.0": false,
"::1": false,
"fe80::1": false,
"fc00::1": false,
"2606:4700::1111": true,
}
for s, want := range cases {
ip := net.ParseIP(s)
if ip == nil {
t.Fatalf("bad test IP %q", s)
}
if got := IsPublicIP(ip); got != want {
t.Errorf("IsPublicIP(%q) = %v, want %v", s, got, want)
}
}
}
func TestSafeHTTPClientBlocksLoopback(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Write([]byte("ok"))
}))
defer srv.Close()
client := NewSafeHTTPClient(5*time.Second, false)
_, err := client.Get(srv.URL)
if err == nil {
t.Fatal("expected request to loopback server to be blocked")
}
}
func TestSafeHTTPClientAllowsLoopbackWhenPermitted(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Write([]byte("ok"))
}))
defer srv.Close()
client := NewSafeHTTPClient(5*time.Second, true)
resp, err := client.Get(srv.URL)
if err != nil {
t.Fatalf("expected request to loopback server to succeed: %v", err)
}
resp.Body.Close()
}
func TestSafeHTTPClientBlocksRedirectToPrivate(t *testing.T) {
blocked := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Write([]byte("should never be reached"))
}))
defer blocked.Close()
// A "public-looking" server (still loopback in this test, but with
// AllowPrivateNetworks=false the initial dial to it would itself be
// blocked — so instead verify redirect scheme enforcement directly
// via CheckRedirect using a context that never dials at all).
client := NewSafeHTTPClient(5*time.Second, false)
req, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, blocked.URL, nil)
if err := client.CheckRedirect(req, nil); err != nil {
t.Fatalf("unexpected error for allowed scheme: %v", err)
}
req.URL.Scheme = "file"
if err := client.CheckRedirect(req, nil); err == nil {
t.Fatal("expected file:// redirect to be rejected")
}
}