Security: - New internal/netguard package: podcast feed/enclosure fetching now refuses to dial non-public IPs (loopback/RFC1918/link-local/cloud metadata/CGNAT), validated per-connection including across redirects, closing an SSRF gap where a malicious or compromised feed URL could probe the server's internal network. Configurable via VIBESONIC_PODCASTS_ALLOW_PRIVATE_NETWORKS for intentional LAN feeds. - Podcast episode downloads capped at 4GB (was unbounded, disk-exhaustion risk) - Cover art decoding now rejects images above a 40-megapixel budget before full decode (decompression-bomb guard) - HTTP server sets ReadHeaderTimeout (slowloris hardening) - Admin folder-scan redirect now validated as same-site instead of trusting the raw Referer header (open-redirect fix) - Legacy Subsonic token/salt auth now uses a constant-time comparison Web UI completion: - Persistent player: shuffle and repeat (off/all/one) controls, wired into queue advance/prev logic and persisted like other player state - Admin user-permissions form: adminRole toggle (with a guard against demoting the last remaining admin) and per-user music-folder access checkboxes, backed by existing schema/enforcement that was previously unreachable from the UI - Playlist M3U8 import/export Docs: added docs/client-compatibility.md (honest tracking template — no client testing has been performed), docs/deployment.md, docs/security.md, docs/backup.md; refreshed README and cross-links; added a footnote in docs/subsonic-compatibility.md distinguishing spec-standard from VibeSonic-original OpenSubsonic extensions. Also added Go fuzz tests for the external-auth CIDR/IP parser and the LRC lyrics parser. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014r98AtcBbevpscWLsfwVvv
27 lines
779 B
Go
27 lines
779 B
Go
package lyrics
|
|
|
|
import "testing"
|
|
|
|
// FuzzParse guards against a crash/panic in the LRC parser when fed
|
|
// arbitrary bytes — lyrics come from sidecar files and embedded tags
|
|
// found while scanning a music library, so the content is effectively
|
|
// untrusted input.
|
|
func FuzzParse(f *testing.F) {
|
|
f.Add("[00:12.34]First line\n[00:15.00]Second line")
|
|
f.Add("[la:en]\n[00:12.34]<00:12.34>Hello <00:12.90>world")
|
|
f.Add("")
|
|
f.Add("[not a tag")
|
|
f.Add("[99:99.999999999999]overflowing timestamp")
|
|
f.Add("[00:12.34][00:15.00]shared timestamp line")
|
|
f.Add("no timestamps at all, just plain text")
|
|
|
|
f.Fuzz(func(t *testing.T, content string) {
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
t.Fatalf("Parse panicked on %q: %v", content, r)
|
|
}
|
|
}()
|
|
Parse(content)
|
|
})
|
|
}
|