Various minor cleanup

src/libs/services/recommendation/impl/playlist-constraints/ConsecutiveArtists.cpp

@@ -21,7 +21,6 @@
 
 #include <algorithm>
 
-#include "core/ILogger.hpp"
 #include "database/Db.hpp"
 #include "database/Release.hpp"
 #include "database/Session.hpp"

src/libs/services/recommendation/impl/playlist-constraints/ConsecutiveArtists.hpp

@@ -21,8 +21,6 @@
 
 #include "IConstraint.hpp"
 
-#include "database/ReleaseId.hpp"
-
 namespace lms::db
 {
     class Db;
@@ -34,6 +32,9 @@ namespace lms::recommendation::PlaylistGeneratorConstraint
     {
     public:
         ConsecutiveArtists(db::Db& db);
+        ~ConsecutiveArtists() override = default;
+        ConsecutiveArtists(const ConsecutiveArtists&) = delete;
+        ConsecutiveArtists& operator=(const ConsecutiveArtists&) = delete;
 
     private:
         float computeScore(const TrackContainer& trackIds, std::size_t trackIndex) override;

src/libs/services/recommendation/impl/playlist-constraints/ConsecutiveReleases.cpp

@@ -19,7 +19,6 @@
 
 #include "ConsecutiveReleases.hpp"
 
-#include "core/ILogger.hpp"
 #include "database/Db.hpp"
 #include "database/Release.hpp"
 #include "database/Session.hpp"
@@ -46,10 +45,10 @@ namespace lms::recommendation::PlaylistGeneratorConstraint
         for (std::size_t i{ 1 }; i < rangeSize; ++i)
         {
             if ((trackIndex >= i) && getReleaseId(trackIds[trackIndex - i]) == releaseId)
-                score += (1.f / static_cast<float>(i));
+                score += (1.F / static_cast<float>(i));
 
             if ((trackIndex + i < trackIds.size()) && getReleaseId(trackIds[trackIndex + i]) == releaseId)
-                score += (1.f / static_cast<float>(i));
+                score += (1.F / static_cast<float>(i));
         }
 
         return score;

src/libs/services/recommendation/impl/playlist-constraints/ConsecutiveReleases.hpp

@@ -34,6 +34,9 @@ namespace lms::recommendation::PlaylistGeneratorConstraint
     {
     public:
         ConsecutiveReleases(db::Db& db);
+        ~ConsecutiveReleases() override = default;
+        ConsecutiveReleases(const ConsecutiveReleases&) = delete;
+        ConsecutiveReleases& operator=(const ConsecutiveReleases&) = delete;
 
     private:
         float computeScore(const std::vector<db::TrackId>& trackIds, std::size_t trackIndex) override;

src/libs/services/recommendation/impl/playlist-constraints/DuplicateTracks.cpp

@@ -26,6 +26,6 @@ namespace lms::recommendation::PlaylistGeneratorConstraint
     float DuplicateTracks::computeScore(const std::vector<db::TrackId>& trackIds, std::size_t trackIndex)
     {
         const auto count{ std::count(std::cbegin(trackIds), std::cend(trackIds), trackIds[trackIndex]) };
-        return count == 1 ? 0 : 1000;
+        return count == 1 ? 0 : 1'000;
     }
 } // namespace lms::recommendation::PlaylistGeneratorConstraint

src/libs/services/recommendation/impl/playlist-constraints/IConstraint.hpp

@@ -19,8 +19,6 @@
 
 #pragma once
 
-#include <vector>
-
 #include "services/recommendation/Types.hpp"
 
 namespace lms::recommendation::PlaylistGeneratorConstraint