From 1477fa125ee88c095ba6e2ccdca71fa91b7ae017 Mon Sep 17 00:00:00 2001 From: emeric Date: Thu, 20 May 2021 16:50:46 +0200 Subject: [PATCH] CodeFactor review --- src/libs/scrobbling/impl/listenbrainz/ListensSynchronizer.hpp | 1 - src/libs/utils/impl/IOContextRunner.cpp | 2 -- src/lms/ui/explore/SearchView.hpp | 1 - src/test/database/Common.hpp | 1 - src/test/database/Track.cpp | 1 - 5 files changed, 6 deletions(-) diff --git a/src/libs/scrobbling/impl/listenbrainz/ListensSynchronizer.hpp b/src/libs/scrobbling/impl/listenbrainz/ListensSynchronizer.hpp index 1a49ed98..511e07e8 100644 --- a/src/libs/scrobbling/impl/listenbrainz/ListensSynchronizer.hpp +++ b/src/libs/scrobbling/impl/listenbrainz/ListensSynchronizer.hpp @@ -67,7 +67,6 @@ namespace Scrobbling::ListenBrainz std::size_t fetchedListenCount{}; std::size_t matchedListenCount{}; std::size_t importedListenCount{}; - }; UserContext& getUserContext(Database::IdType userId); diff --git a/src/libs/utils/impl/IOContextRunner.cpp b/src/libs/utils/impl/IOContextRunner.cpp index 038f7ff5..888dd786 100644 --- a/src/libs/utils/impl/IOContextRunner.cpp +++ b/src/libs/utils/impl/IOContextRunner.cpp @@ -40,10 +40,8 @@ IOContextRunner::stop() IOContextRunner::~IOContextRunner() { - stop(); for (std::thread& t : _threads) t.join(); - } diff --git a/src/lms/ui/explore/SearchView.hpp b/src/lms/ui/explore/SearchView.hpp index 590d941f..e7a802b4 100644 --- a/src/lms/ui/explore/SearchView.hpp +++ b/src/lms/ui/explore/SearchView.hpp @@ -49,7 +49,6 @@ namespace UserInterface void refreshView(const Wt::WString& searchText); private: - // same order as in the menu enum class Mode { diff --git a/src/test/database/Common.hpp b/src/test/database/Common.hpp index 82f9115c..056ca415 100644 --- a/src/test/database/Common.hpp +++ b/src/test/database/Common.hpp @@ -124,7 +124,6 @@ class TmpDatabase final const std::filesystem::path _tmpFile {std::tmpnam(nullptr)}; ScopedFileDeleter fileDeleter {_tmpFile}; Database::Db _db {_tmpFile}; - }; class DatabaseFixture : public ::testing::Test diff --git a/src/test/database/Track.cpp b/src/test/database/Track.cpp index 1223fc9c..b5de2e56 100644 --- a/src/test/database/Track.cpp +++ b/src/test/database/Track.cpp @@ -42,7 +42,6 @@ TEST_F(DatabaseFixture, SingleTrack) TEST_F(DatabaseFixture, MultipleTracksSearchByFilter) { - ScopedTrack track1 {session, ""}; ScopedTrack track2 {session, ""}; ScopedTrack track3 {session, ""};