owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Removed unnecessary write access to the DB

Browse Source
This commit is contained in:
emeric
2024-03-09 19:22:06 +01:00
parent d6fd95ab44
commit 15b4a4601e
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/services/auth/impl/AuthServiceBase.cpp
+9 -2
View File
@@ -36,11 +36,18 @@ namespace Auth
UserId AuthServiceBase::getOrCreateUser(std::string_view loginName) UserId AuthServiceBase::getOrCreateUser(std::string_view loginName)
{ {
Session& session{ getDbSession() }; Session& session{ getDbSession() };
auto transaction{ session.createWriteTransaction() };
User::pointer user{ User::find(session, loginName) }; User::pointer user;
{
auto transaction{ session.createReadTransaction() };
user = User::find(session, loginName);
}
if (!user) if (!user)
{ {
auto transaction{ session.createWriteTransaction() };
const UserType type{ User::getCount(session) == 0 ? UserType::ADMIN : UserType::REGULAR }; const UserType type{ User::getCount(session) == 0 ? UserType::ADMIN : UserType::REGULAR };
LMS_LOG(AUTH, DEBUG, "Creating user '" << loginName << "', admin = " << (type == UserType::ADMIN)); LMS_LOG(AUTH, DEBUG, "Creating user '" << loginName << "', admin = " << (type == UserType::ADMIN));