owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Relaxed max name lengths, fixes #765

Browse Source
This commit is contained in:
emeric
2025-11-09 14:01:58 +01:00
parent 6dc386cfd7
commit 1a2f317ddb
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/database/impl/objects/Release.cpp
+8 -8
View File
@@ -289,7 +289,7 @@ namespace lms::db
{
// As we use the name to uniquely identoify release type, we must throw (and not truncate)
if (name.size() > _maxNameLength)
throw Exception{ "Country name is too long: " + std::string{ name } + "'" };
throw Exception{ "Country name is too long: '" + std::string{ name } + "'" };
}
Country::pointer Country::create(Session& session, std::string_view name)
@@ -314,7 +314,7 @@ namespace lms::db
session.checkReadTransaction();
if (name.size() > _maxNameLength)
throw Exception{ "Requeted Country name is too long: " + std::string{ name } + "'" };
throw Exception{ "Country name is too long: '" + std::string{ name } + "'" };
return utils::fetchQuerySingleResult(session.getDboSession()->query<Wt::Dbo::ptr<Country>>("SELECT c from country c").where("c.name = ?").bind(name));
}
@@ -331,9 +331,9 @@ namespace lms::db
Label::Label(std::string_view name)
: _name{ name }
{
// As we use the name to uniquely identoify release type, we must throw (and not truncate)
// As we use the name to uniquely identify this label, we must throw (and not truncate)
if (name.size() > _maxNameLength)
throw Exception{ "Label name is too long: " + std::string{ name } + "'" };
throw Exception{ "Label name is too long: '" + std::string{ name } + "'" };
}
Label::pointer Label::create(Session& session, std::string_view name)
@@ -358,7 +358,7 @@ namespace lms::db
session.checkReadTransaction();
if (name.size() > _maxNameLength)
throw Exception{ "Requeted Label name is too long: " + std::string{ name } + "'" };
throw Exception{ "Label name is too long: '" + std::string{ name } + "'" };
return utils::fetchQuerySingleResult(session.getDboSession()->query<Wt::Dbo::ptr<Label>>("SELECT l from label l").where("l.name = ?").bind(name));
}
@@ -393,9 +393,9 @@ namespace lms::db
ReleaseType::ReleaseType(std::string_view name)
: _name{ name }
{
// As we use the name to uniquely identoify release type, we must throw (and not truncate)
// As we use the name to uniquely identify release types, we must throw (and not truncate)
if (name.size() > _maxNameLength)
throw Exception{ "ReleaseType name is too long: " + std::string{ name } + "'" };
throw Exception{ "ReleaseType is too long: '" + std::string{ name } + "'" };
}
ReleaseType::pointer ReleaseType::create(Session& session, std::string_view name)
@@ -420,7 +420,7 @@ namespace lms::db
session.checkReadTransaction();
if (name.size() > _maxNameLength)
throw Exception{ "Requeted ReleaseType name is too long: " + std::string{ name } + "'" };
throw Exception{ "ReleaseType is too long: '" + std::string{ name } + "'" };
return utils::fetchQuerySingleResult(session.getDboSession()->query<Wt::Dbo::ptr<ReleaseType>>("SELECT r_t from release_type r_t").where("r_t.name = ?").bind(name));
}
src/libs/database/include/database/objects/Release.hpp
+3 -3
View File
@@ -78,7 +78,7 @@ namespace lms::db
}
private:
static constexpr std::size_t _maxNameLength{ 32 };
static constexpr std::size_t _maxNameLength{ 1024 };
friend class Session;
Country(std::string_view name);
@@ -110,7 +110,7 @@ namespace lms::db
}
private:
static constexpr std::size_t _maxNameLength{ 512 };
static constexpr std::size_t _maxNameLength{ 1024 };
friend class Session;
Label(std::string_view name);
@@ -142,7 +142,7 @@ namespace lms::db
}
private:
static constexpr std::size_t _maxNameLength{ 512 };
static constexpr std::size_t _maxNameLength{ 1024 };
friend class Session;
ReleaseType(std::string_view name);