Some changes to please codeQL

src/libs/services/scrobbling/impl/listenbrainz/FeedbacksSynchronizer.cpp

@@ -19,6 +19,7 @@
 
 #include "ListenBrainzScrobbler.hpp"
 
+#include <tuple>
 #include <boost/asio/bind_executor.hpp>
 #include <Wt/Json/Array.h>
 #include <Wt/Json/Object.h>
@@ -234,8 +235,7 @@ namespace Scrobbling::ListenBrainz
 		auto itContext {_userContexts.find(userId)};
 		if (itContext == std::cend(_userContexts))
 		{
-			[[maybe_unused]] auto [itNewContext, inserted] {_userContexts.emplace(userId, userId)};
-			itContext = itNewContext;
+			std::tie(itContext, std::ignore) = _userContexts.emplace(userId, userId);
 		}
 
 		return itContext->second;
@@ -246,8 +246,7 @@ namespace Scrobbling::ListenBrainz
 	{
 		return std::any_of(std::cbegin(_userContexts), std::cend(_userContexts), [](const auto& contextEntry)
 				{
-					[[maybe_unused]] const auto& [userId, context] {contextEntry};
-					return context.syncing;
+					return contextEntry.second.syncing;
 				});
 	}
 

src/libs/services/scrobbling/impl/listenbrainz/ListensSynchronizer.cpp

@@ -19,6 +19,7 @@
 
 #include "ListenBrainzScrobbler.hpp"
 
+#include <tuple>
 #include <boost/asio/bind_executor.hpp>
 #include <Wt/Json/Array.h>
 #include <Wt/Json/Object.h>
@@ -354,8 +355,7 @@ namespace Scrobbling::ListenBrainz
 		auto itContext {_userContexts.find(userId)};
 		if (itContext == std::cend(_userContexts))
 		{
-			[[maybe_unused]] auto [itNewContext, inserted] {_userContexts.emplace(userId, userId)};
-			itContext = itNewContext;
+			std::tie(itContext, std::ignore) = _userContexts.emplace(userId, userId);
 		}
 
 		return itContext->second;
@@ -366,8 +366,7 @@ namespace Scrobbling::ListenBrainz
 	{
 		return std::any_of(std::cbegin(_userContexts), std::cend(_userContexts), [](const auto& contextEntry)
 				{
-					[[maybe_unused]] const auto& [userId, context] {contextEntry};
-					return context.syncing;
+					return contextEntry.second.syncing;
 				});
 	}
 

src/lms/ui/explore/ReleaseView.cpp

@@ -118,7 +118,6 @@ showReleaseInfoModal(Database::ReleaseId releaseId)
 		artistTable->addWidget(std::move(artistsEntry));
 	}
 
-
 	// TODO: save in DB and mean all this
 	for (TrackId trackId : Track::find(LmsApp->getDbSession(), Track::FindParameters {}.setRelease(releaseId).setRange(Range {0, 1})).results)
 	{