owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Some changes to please codeQL

Browse Source
This commit is contained in:
emeric
2022-12-17 13:58:56 +01:00
parent 4f885d2295
commit 1ca4b31b8d
3 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/services/scrobbling/impl/listenbrainz/FeedbacksSynchronizer.cpp
+3 -4
View File
@@ -19,6 +19,7 @@
#include "ListenBrainzScrobbler.hpp"
#include <tuple>
#include <boost/asio/bind_executor.hpp>
#include <Wt/Json/Array.h>
#include <Wt/Json/Object.h>
@@ -234,8 +235,7 @@ namespace Scrobbling::ListenBrainz
auto itContext {_userContexts.find(userId)};
if (itContext == std::cend(_userContexts))
{
[[maybe_unused]] auto [itNewContext, inserted] {_userContexts.emplace(userId, userId)};
itContext = itNewContext;
std::tie(itContext, std::ignore) = _userContexts.emplace(userId, userId);
}
return itContext->second;
@@ -246,8 +246,7 @@ namespace Scrobbling::ListenBrainz
{
return std::any_of(std::cbegin(_userContexts), std::cend(_userContexts), [](const auto& contextEntry)
{
[[maybe_unused]] const auto& [userId, context] {contextEntry};
return context.syncing;
return contextEntry.second.syncing;
});
}
src/libs/services/scrobbling/impl/listenbrainz/ListensSynchronizer.cpp
+3 -4
View File
@@ -19,6 +19,7 @@
#include "ListenBrainzScrobbler.hpp"
#include <tuple>
#include <boost/asio/bind_executor.hpp>
#include <Wt/Json/Array.h>
#include <Wt/Json/Object.h>
@@ -354,8 +355,7 @@ namespace Scrobbling::ListenBrainz
auto itContext {_userContexts.find(userId)};
if (itContext == std::cend(_userContexts))
{
[[maybe_unused]] auto [itNewContext, inserted] {_userContexts.emplace(userId, userId)};
itContext = itNewContext;
std::tie(itContext, std::ignore) = _userContexts.emplace(userId, userId);
}
return itContext->second;
@@ -366,8 +366,7 @@ namespace Scrobbling::ListenBrainz
{
return std::any_of(std::cbegin(_userContexts), std::cend(_userContexts), [](const auto& contextEntry)
{
[[maybe_unused]] const auto& [userId, context] {contextEntry};
return context.syncing;
return contextEntry.second.syncing;
});
}