Introduced an option to use a release image when no artist image is available, fixes #639

src/libs/database/impl/Migration.cpp

@@ -35,7 +35,7 @@ namespace lms::db
 {
     namespace
     {
-        static constexpr Version LMS_DATABASE_VERSION{ 93 };
+        static constexpr Version LMS_DATABASE_VERSION{ 94 };
     }
 
     VersionInfo::VersionInfo()
@@ -1380,6 +1380,12 @@ FROM artist)");
         utils::executeCommand(*session.getDboSession(), "UPDATE scan_settings SET audio_scan_version = audio_scan_version + 1");
     }
 
+    void migrateFromV93(Session& session)
+    {
+        // add artist_image_fallback_to_release in ScanSettings
+        utils::executeCommand(*session.getDboSession(), "ALTER TABLE scan_settings ADD COLUMN artist_image_fallback_to_release BOOLEAN NOT NULL DEFAULT(false)");
+    }
+
     bool doDbMigration(Session& session)
     {
         constexpr std::string_view outdatedMsg{ "Outdated database, please rebuild it (delete the .db file and restart)" };
@@ -1449,6 +1455,7 @@ FROM artist)");
             { 90, migrateFromV90 },
             { 91, migrateFromV91 },
             { 92, migrateFromV92 },
+            { 93, migrateFromV93 },
         };
 
         bool migrationPerformed{};

src/libs/database/impl/ScanSettings.cpp

@@ -121,14 +121,17 @@ namespace lms::db
 
     void ScanSettings::setSkipSingleReleasePlayLists(bool value)
     {
-        if (_skipSingleReleasePlayLists != value)
-            _skipSingleReleasePlayLists = value;
+        _skipSingleReleasePlayLists = value;
     }
 
     void ScanSettings::setAllowMBIDArtistMerge(bool value)
     {
-        if (_allowMBIDArtistMerge != value)
-            _allowMBIDArtistMerge = value;
+        _allowMBIDArtistMerge = value;
+    }
+
+    void ScanSettings::setArtistImageFallbackToReleaseField(bool value)
+    {
+        _artistImageFallbackToReleaseField = value;
     }
 
     void ScanSettings::incAudioScanVersion()

src/libs/database/include/database/ScanSettings.hpp

@@ -74,6 +74,7 @@ namespace lms::db
         std::vector<std::string> getArtistsToNotSplit() const;
         bool getSkipSingleReleasePlayLists() const { return _skipSingleReleasePlayLists; }
         bool getAllowMBIDArtistMerge() const { return _allowMBIDArtistMerge; }
+        bool getArtistImageFallbackToReleaseField() const { return _artistImageFallbackToReleaseField; }
 
         // Setters
         void setUpdateStartTime(Wt::WTime t) { _startTime = t; }
@@ -85,6 +86,7 @@ namespace lms::db
         void setDefaultTagDelimiters(std::span<const std::string_view> delimiters);
         void setSkipSingleReleasePlayLists(bool value);
         void setAllowMBIDArtistMerge(bool value);
+        void setArtistImageFallbackToReleaseField(bool value);
 
         template<class Action>
         void persist(Action& a)
@@ -101,6 +103,7 @@ namespace lms::db
             Wt::Dbo::field(a, _defaultTagDelimiters, "default_tag_delimiters");
             Wt::Dbo::field(a, _skipSingleReleasePlayLists, "skip_single_release_playlists");
             Wt::Dbo::field(a, _allowMBIDArtistMerge, "allow_mbid_artist_merge");
+            Wt::Dbo::field(a, _artistImageFallbackToReleaseField, "artist_image_fallback_to_release");
         }
 
     private:
@@ -123,5 +126,6 @@ namespace lms::db
         std::string _defaultTagDelimiters;
         bool _skipSingleReleasePlayLists{};
         bool _allowMBIDArtistMerge{};
+        bool _artistImageFallbackToReleaseField{};
     };
 } // namespace lms::db