CodeCL review

This commit is contained in:
emeric
2026-06-06 14:47:50 +02:00
parent 7bdb6f8e1f
commit 26dc9fa06b
@@ -19,7 +19,7 @@
#pragma once #pragma once
#include <limits> #include <optional>
#include <unordered_map> #include <unordered_map>
#include "database/objects/TrackId.hpp" #include "database/objects/TrackId.hpp"
@@ -53,14 +53,17 @@ namespace lms::recommendation
if (itCand == _trackVectors.cend()) if (itCand == _trackVectors.cend())
return {}; return {};
float best{ std::numeric_limits<float>::max() }; std::optional<float> best;
for (const db::TrackId seedId : context.seedTrackIds) for (const db::TrackId seedId : context.seedTrackIds)
{ {
const auto it{ _trackVectors.find(seedId) }; const auto it{ _trackVectors.find(seedId) };
if (it != _trackVectors.cend()) if (it != _trackVectors.cend())
best = std::min(best, math::computeNormalizedCosineDistance(*it->second, *itCand->second)); {
const float dist{ math::computeNormalizedCosineDistance(*it->second, *itCand->second) };
best = best ? std::min(*best, dist) : dist;
}
} }
return (best == std::numeric_limits<float>::max()) ? 0.F : best; return best.value_or(0.F);
} }
private: private: