owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed recently added artists sort , fixes #632

Browse Source
This commit is contained in:
emeric
2025-03-09 12:05:57 +01:00
parent 8b8105c515
commit 38fde8bae0
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/database/impl/Artist.cpp
+2 -2
View File
@@ -169,10 +169,10 @@ namespace lms::db
query.orderBy("RANDOM()"); query.orderBy("RANDOM()");
break; break;
case ArtistSortMethod::LastWrittenDesc: case ArtistSortMethod::LastWrittenDesc:
query.orderBy("MAX(t.file_last_write) DESC"); query.orderBy("MAX(t.file_last_write) DESC, a.sort_name");
break; break;
case ArtistSortMethod::AddedDesc: case ArtistSortMethod::AddedDesc:
query.orderBy("MAX(t.file_added) DESC"); query.orderBy("MIN(t.file_added) DESC, a.sort_name");
break; break;
case ArtistSortMethod::StarredDateDesc: case ArtistSortMethod::StarredDateDesc:
assert(params.starringUser.isValid()); assert(params.starringUser.isValid());
src/libs/database/test/Artist.cpp
+2 -2
View File
@@ -768,8 +768,8 @@ namespace lms::db::tests
auto transaction{ session.createReadTransaction() }; auto transaction{ session.createReadTransaction() };
const auto artists{ Artist::findIds(session, Artist::FindParameters{}.setSortMethod(ArtistSortMethod::AddedDesc)) }; const auto artists{ Artist::findIds(session, Artist::FindParameters{}.setSortMethod(ArtistSortMethod::AddedDesc)) };
ASSERT_EQ(artists.results.size(), 4); ASSERT_EQ(artists.results.size(), 4);
EXPECT_EQ(artists.results[0], artistA.getId()); EXPECT_EQ(artists.results[0], artistD.getId());
EXPECT_EQ(artists.results[1], artistD.getId()); EXPECT_EQ(artists.results[1], artistA.getId());
EXPECT_EQ(artists.results[2], artistB.getId()); EXPECT_EQ(artists.results[2], artistB.getId());
EXPECT_EQ(artists.results[3], artistC.getId()); EXPECT_EQ(artists.results[3], artistC.getId());
} }