owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added more unit tests to check behavior when artist and mbid counts are not equal, ref #782

Browse Source
This commit is contained in:
emeric
2025-11-21 21:09:16 +01:00
parent d69827c2a2
commit 41f59c2054
1 changed files with 51 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/services/scanner/test/TrackMetadataParser.cpp
+51
View File
@@ -720,6 +720,57 @@ namespace lms::scanner::tests
EXPECT_EQ(track.artistDisplayName, "Artist1, Artist2"); // reconstruct the artist display name EXPECT_EQ(track.artistDisplayName, "Artist1, Artist2"); // reconstruct the artist display name
} }
TEST(TrackMetadataParser, heterogeneousArtistMbids)
{
{
const TestTagReader testTags{
{
{ audio::TagType::Artists, { "MyArtist" } },
{ audio::TagType::MusicBrainzArtistID, { "970f720b-c955-4ae7-870e-3a3716577cbf", "58eea0c6-1327-4354-8438-13e581894f35" } },
{ audio::TagType::Album, { "MyAlbum" } },
{ audio::TagType::AlbumArtists, { "MyArtist" } },
{ audio::TagType::MusicBrainzReleaseArtistID, { "970f720b-c955-4ae7-870e-3a3716577cbf", "58eea0c6-1327-4354-8438-13e581894f35" } },
}
};
const Track track{ TrackMetadataParser{}.parseTrackMetaData(testTags) };
ASSERT_EQ(track.artists.size(), 1);
EXPECT_EQ(track.artists[0].name, "MyArtist");
EXPECT_EQ(track.artists[0].mbid, std::nullopt);
ASSERT_TRUE(track.medium.has_value());
ASSERT_TRUE(track.medium->release.has_value());
ASSERT_EQ(track.medium->release->artists.size(), 1);
EXPECT_EQ(track.medium->release->artists[0].name, "MyArtist");
EXPECT_EQ(track.medium->release->artists[0].mbid, std::nullopt);
}
{
const TestTagReader testTags{
{
{ audio::TagType::Artist, { "MyArtist" } },
{ audio::TagType::MusicBrainzArtistID, { "970f720b-c955-4ae7-870e-3a3716577cbf", "58eea0c6-1327-4354-8438-13e581894f35" } },
{ audio::TagType::Album, { "MyAlbum" } },
{ audio::TagType::AlbumArtist, { "MyArtist" } },
{ audio::TagType::MusicBrainzReleaseArtistID, { "970f720b-c955-4ae7-870e-3a3716577cbf", "58eea0c6-1327-4354-8438-13e581894f35" } },
}
};
const Track track{ TrackMetadataParser{}.parseTrackMetaData(testTags) };
ASSERT_EQ(track.artists.size(), 1);
EXPECT_EQ(track.artists[0].name, "MyArtist");
EXPECT_EQ(track.artists[0].mbid, std::nullopt);
ASSERT_TRUE(track.medium.has_value());
ASSERT_TRUE(track.medium->release.has_value());
ASSERT_EQ(track.medium->release->artists.size(), 1);
EXPECT_EQ(track.medium->release->artists[0].name, "MyArtist");
EXPECT_EQ(track.medium->release->artists[0].mbid, std::nullopt);
}
}
TEST(TrackMetadataParser, release_sortNameFallback) TEST(TrackMetadataParser, release_sortNameFallback)
{ {
const TestTagReader testTags{ const TestTagReader testTags{