Extracted browsing entry points

src/libs/subsonic/impl/responses/Bookmark.cpp

@@ -21,7 +21,6 @@
 
 #include "services/database/TrackBookmark.hpp"
 #include "services/database/User.hpp"
-#include "SubsonicResponse.hpp"
 
 namespace API::Subsonic
 {

src/libs/subsonic/impl/responses/Genre.cpp

@@ -0,0 +1,36 @@
+/*
+ * Copyright (C) 2023 Emeric Poupon
+ *
+ * This file is part of LMS.
+ *
+ * LMS is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * LMS is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with LMS.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "responses/Genre.hpp"
+
+#include "services/database/Cluster.hpp"
+
+namespace API::Subsonic
+{
+	Response::Node createGenreNode(const Database::Cluster::pointer& cluster)
+	{
+		Response::Node clusterNode;
+
+		clusterNode.setValue(cluster->getName());
+		clusterNode.setAttribute("songCount", cluster->getTracksCount());
+		clusterNode.setAttribute("albumCount", cluster->getReleasesCount());
+
+		return clusterNode;
+	}
+}

src/libs/subsonic/impl/responses/Genre.hpp

@@ -0,0 +1,35 @@
+/*
+ * Copyright (C) 2023 Emeric Poupon
+ *
+ * This file is part of LMS.
+ *
+ * LMS is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * LMS is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with LMS.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#pragma once
+
+#include "services/database/Cluster.hpp"
+
+#include "services/database/Object.hpp"
+#include "SubsonicResponse.hpp"
+
+namespace Database
+{
+    class Cluster;
+}
+
+namespace API::Subsonic
+{
+    Response::Node createGenreNode(const Database::ObjectPtr<Database::Cluster>& cluster);
+}

src/libs/subsonic/impl/responses/Song.cpp

@@ -31,6 +31,7 @@
 #include "utils/String.hpp"
 #include "responses/Artist.hpp"
 #include "SubsonicId.hpp"
+#include "Utils.hpp"
 
 namespace API::Subsonic
 {
@@ -54,11 +55,6 @@ namespace API::Subsonic
             return "";
         }
 
-        std::string makeNameFilesystemCompatible(std::string_view name)
-        {
-            return StringUtils::replaceInString(name, "/", "_");
-        }
-
         std::string getTrackPath(const Track::pointer& track)
         {
             std::string path;
@@ -75,9 +71,9 @@ namespace API::Subsonic
                 if (artists.size() > 1)
                     path = "Various Artists/";
                 else if (artists.size() == 1)
-                    path = makeNameFilesystemCompatible(artists.front()->getName()) + "/";
+                    path = Utils::makeNameFilesystemCompatible(artists.front()->getName()) + "/";
 
-                path += makeNameFilesystemCompatible(track->getRelease()->getName()) + "/";
+                path += Utils::makeNameFilesystemCompatible(track->getRelease()->getName()) + "/";
             }
 
             if (track->getDiscNumber())
@@ -85,7 +81,7 @@ namespace API::Subsonic
             if (track->getTrackNumber())
                 path += std::to_string(*track->getTrackNumber()) + "-";
 
-            path += makeNameFilesystemCompatible(track->getName());
+            path += Utils::makeNameFilesystemCompatible(track->getName());
 
             if (track->getPath().has_extension())
                 path += track->getPath().extension();