owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Relaxed checks, more explicit errors, ref #797

Browse Source
This commit is contained in:
emeric
2026-01-04 16:30:52 +01:00
parent c39a26c4f6
commit 5b90b1997e
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/subsonic/impl/endpoints/MediaRetrieval.cpp
+6 -2
View File
@@ -155,10 +155,14 @@ namespace lms::api::subsonic
requestedFormat = userTranscodeFormatToOutputFormat(context.getUser()->getSubsonicDefaultTranscodingOutputFormat()); requestedFormat = userTranscodeFormatToOutputFormat(context.getUser()->getSubsonicDefaultTranscodingOutputFormat());
} }
// Extra checks when requesting a lossless format
if (requestedFormat && core::media::getCodecDesc(requestedFormat->codec).isLossless) if (requestedFormat && core::media::getCodecDesc(requestedFormat->codec).isLossless)
{ {
if (maxBitRate > 0) if (!core::media::getCodecDesc(audioFileInfo.audioProperties.codec).isLossless && maxBitRate > 0)
throw BadParameterGenericError{ "maxBitRate", "Cannot limit bitrate when requesting a lossless format" }; throw BadParameterGenericError{ "maxBitRate", "Cannot limit bitrate when requesting a lossless format from a lossy source" };
if (core::media::getCodecDesc(audioFileInfo.audioProperties.codec).isLossless && maxBitRate > 0 && audioFileInfo.audioProperties.bitrate > maxBitRate)
throw BadParameterGenericError{ "maxBitRate", "Cannot honor maxBitRate, source is lossless with higher bitrate (" + std::to_string(audioFileInfo.audioProperties.bitrate) + " bps)" };
// we accept to transcode from a lossy format to a lossless one // we accept to transcode from a lossy format to a lossless one
} }