From 5cfbbeca650bde42ebf8dd40a563673c42d4c972 Mon Sep 17 00:00:00 2001 From: emeric Date: Sat, 18 Jan 2025 14:45:31 +0100 Subject: [PATCH] Fixed build with taglib < 2.0.1 --- src/libs/metadata/impl/TagLibTagReader.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/libs/metadata/impl/TagLibTagReader.cpp b/src/libs/metadata/impl/TagLibTagReader.cpp index 9fffd6d3..0acf72b1 100644 --- a/src/libs/metadata/impl/TagLibTagReader.cpp +++ b/src/libs/metadata/impl/TagLibTagReader.cpp @@ -48,6 +48,10 @@ #include "core/String.hpp" #include "metadata/Exception.hpp" +#if (TAGLIB_MAJOR_VERSION > 2) || (TAGLIB_MAJOR_VERSION == 2 && TAGLIB_MINOR_VERSION > 0) + #define TAGLIB_HAS_MP4_ITEM_TYPE +#endif + namespace lms::metadata { namespace @@ -322,14 +326,18 @@ namespace lms::metadata { if (const TagLib::MP4::Item coverItem{ mp4File->tag()->item("covr") }; coverItem.isValid()) { +#if TAGLIB_HAS_MP4_ITEM_TYPE if (coverItem.type() == TagLib::MP4::Item::Type::CoverArtList) +#endif _hasEmbeddedCover = true; } // Taglib does not expose rtng in properties if (const TagLib::MP4::Item rtngItem{ mp4File->tag()->item("rtng") }; rtngItem.isValid()) { +#if TAGLIB_HAS_MP4_ITEM_TYPE if (rtngItem.type() == TagLib::MP4::Item::Type::Byte) +#endif _propertyMap["ITUNESADVISORY"] = TagLib::String{ std::to_string(rtngItem.toByte()) }; }