owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed useless joins

Browse Source
This commit is contained in:
emeric
2026-06-18 00:17:16 +02:00
parent cf6ad12a44
commit 5ecdc58b97
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/database/impl/objects/Track.cpp
+10 -10
View File
@@ -768,8 +768,7 @@ namespace lms::db
std::ostringstream oss;
oss << "SELECT a from artist a"
" INNER JOIN track_artist_link t_a_l ON a.id = t_a_l.artist_id"
" INNER JOIN track t ON t.id = t_a_l.track_id";
" INNER JOIN track_artist_link t_a_l ON a.id = t_a_l.artist_id";
if (!linkTypes.empty())
{
@@ -780,6 +779,7 @@ namespace lms::db
{
if (!first)
oss << ", ";
oss << "?";
first = false;
}
@@ -790,7 +790,7 @@ namespace lms::db
for (TrackArtistLinkType type : linkTypes)
query.bind(type);
query.where("t.id = ?").bind(getId());
query.where("t_a_l.track_id = ?").bind(getId());
query.groupBy("t_a_l.artist_id");
query.orderBy("t_a_l.id");
@@ -802,30 +802,30 @@ namespace lms::db
assert(self());
assert(session());
std::ostringstream oss;
oss << "SELECT t_a_l.artist_id FROM track_artist_link t_a_l"
" INNER JOIN track t ON t.id = t_a_l.track_id";
auto query{ session()->query<ArtistId>("SELECT t_a_l.artist_id FROM track_artist_link t_a_l") };
if (!linkTypes.empty())
{
oss << " AND t_a_l.type IN (";
std::ostringstream oss;
oss << "t_a_l.type IN (";
bool first{ true };
for ([[maybe_unused]] TrackArtistLinkType type : linkTypes)
{
if (!first)
oss << ", ";
oss << "?";
first = false;
}
oss << ")";
}
auto query{ session()->query<ArtistId>(oss.str()) };
query.where(oss.str());
for (TrackArtistLinkType type : linkTypes)
query.bind(type);
}
query.where("t.id = ?").bind(getId());
query.where("t_a_l.track_id = ?").bind(getId());
query.groupBy("t_a_l.artist_id");
query.orderBy("t_a_l.id");