Merge branch 'develop' into subsonic-custom-allocator

.clang-tidy

@@ -6,6 +6,8 @@ AnalyzeTemporaryDtors: false
 FormatStyle:     none
 User:            ''
 CheckOptions:
+  - key:             misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic   
+    value:           '1'
   - key:             readability-identifier-naming.IgnoreClassesWithAllMemberVariablesBeingPublic
     value:           '1'
   - key:             cppcoreguidelines-avoid-do-while.IgnoreMacros

CMakeLists.txt

@@ -82,6 +82,10 @@ if (BUILD_BENCHMARKS)
 	message(STATUS "Building benchmarks")
 endif()
 
+if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
+    add_definitions(-DNDEBUG)
+endif()
+
 add_subdirectory(src)
 
 install(DIRECTORY approot DESTINATION share/lms)

src/libs/core/CMakeLists.txt

@@ -38,7 +38,7 @@ target_link_libraries(lmscore PUBLIC
 	Wt::Wt
 	)
 
-install(TARGETS lmscore DESTINATION lib ${CMAKE_INSTALL_LIBDIR})
+install(TARGETS lmscore DESTINATION ${CMAKE_INSTALL_LIBDIR})
 
 if(BUILD_TESTING)
 	add_subdirectory(test)

src/libs/database/CMakeLists.txt

@@ -23,7 +23,7 @@ add_library(lmsdatabase SHARED
 	impl/Utils.cpp
 	)
 
-if (CMAKE_BUILD_TYPE MATCHES "Debug")
+if (CMAKE_BUILD_TYPE STREQUAL "Debug")
 	target_sources(lmsdatabase PRIVATE impl/TransactionChecker.cpp)
 endif()
 

src/libs/database/impl/Artist.cpp

@@ -40,6 +40,7 @@ namespace lms::db
         {
             session.checkReadTransaction();
 
+            // TODO remove distinct and use group by
             auto query{ session.getDboSession().query<ResultType>("SELECT DISTINCT " + std::string{ itemToSelect } + " FROM artist a") };
             if (params.sortMethod == ArtistSortMethod::LastWritten
                 || params.writtenAfter.isValid()
@@ -64,13 +65,13 @@ namespace lms::db
                 std::vector<std::string> clauses;
                 std::vector<std::string> sortClauses;
 
-                for (std::string_view keyword : params.keywords)
+                for (const std::string_view keyword : params.keywords)
                 {
                     clauses.push_back("a.name LIKE ? ESCAPE '" ESCAPE_CHAR_STR "'");
                     query.bind("%" + utils::escapeLikeKeyword(keyword) + "%");
                 }
 
-                for (std::string_view keyword : params.keywords)
+                for (const std::string_view keyword : params.keywords)
                 {
                     sortClauses.push_back("a.sort_name LIKE ? ESCAPE '" ESCAPE_CHAR_STR "'");
                     query.bind("%" + utils::escapeLikeKeyword(keyword) + "%");
@@ -184,6 +185,31 @@ namespace lms::db
         return session.getDboSession().query<int>("SELECT COUNT(*) FROM artist");
     }
 
+    void Artist::find(Session& session, ArtistId& lastRetrievedArtist, std::size_t count, const std::function<void(const Artist::pointer&)>& func, MediaLibraryId library)
+    {
+        session.checkReadTransaction();
+
+        auto query{ session.getDboSession().query<Wt::Dbo::ptr<Artist>>("SELECT a FROM artist a")
+            .orderBy("a.id")
+            .where("a.id > ?").bind(lastRetrievedArtist)
+            .limit(static_cast<int>(count)) };
+
+        if (library.isValid())
+        {
+            query.join("track t ON t.id = t_a_l.track_id");
+            query.join("track_artist_link t_a_l ON t_a_l.artist_id = a.id");
+            query.where("t.media_library_id = ?").bind(library);
+        }
+
+        auto collection{ query.resultList() };
+
+        for (auto itResult{ collection.begin() }; itResult != collection.end(); ++itResult)
+        {
+            func(*itResult);
+            lastRetrievedArtist = (*itResult)->getId();
+        }
+    }
+
     std::vector<Artist::pointer> Artist::find(Session& session, std::string_view name)
     {
         session.checkReadTransaction();
@@ -286,7 +312,7 @@ namespace lms::db
             .groupBy("a.id")
             .orderBy("COUNT(*) DESC, RANDOM()") };
 
-        for (TrackArtistLinkType type : artistLinkTypes)
+        for (const TrackArtistLinkType type : artistLinkTypes)
             query.bind(type);
 
         return utils::execQuery<ArtistId>(query, range);
@@ -304,7 +330,7 @@ namespace lms::db
         where.And(WhereClause("a.id = ?")).bind(getId().toString());
         {
             WhereClause clusterClause;
-            for (ClusterTypeId clusterTypeId : clusterTypeIds)
+            for (const ClusterTypeId clusterTypeId : clusterTypeIds)
                 clusterClause.Or(WhereClause("c_type.id = ?")).bind(clusterTypeId.toString());
 
             where.And(clusterClause);
@@ -320,7 +346,7 @@ namespace lms::db
         Wt::Dbo::collection<Wt::Dbo::ptr<Cluster>> queryRes = query;
 
         std::map<ClusterTypeId, std::vector<Cluster::pointer>> clustersByType;
-        for (Cluster::pointer cluster : queryRes)
+        for (const Cluster::pointer& cluster : queryRes)
         {
             if (clustersByType[cluster->getType()->getId()].size() < size)
                 clustersByType[cluster->getType()->getId()].push_back(cluster);

src/libs/database/impl/Release.cpp

@@ -293,6 +293,30 @@ namespace lms::db
         return utils::execQuery<ReleaseId>(query, range);
     }
 
+    void Release::find(Session& session, ReleaseId& lastRetrievedRelease, std::size_t count, const std::function<void(const Release::pointer&)>& func, MediaLibraryId library)
+    {
+        session.checkReadTransaction();
+
+        auto query{ session.getDboSession().query<Wt::Dbo::ptr<Release>>("SELECT r FROM release r")
+            .orderBy("r.id")
+            .where("r.id > ?").bind(lastRetrievedRelease)
+            .limit(static_cast<int>(count)) };
+
+        if (library.isValid())
+        {
+            query.join("track t ON t.release_id = r.id");
+            query.where("t.media_library_id = ?").bind(library);
+        }
+
+        auto collection{ query.resultList() };
+
+        for (auto itResult{ collection.begin() }; itResult != collection.end(); ++itResult)
+        {
+            func(*itResult);
+            lastRetrievedRelease = (*itResult)->getId();
+        }
+    }
+
     RangeResults<Release::pointer> Release::find(Session& session, const FindParameters& params)
     {
         session.checkReadTransaction();

src/libs/database/include/database/Artist.hpp

@@ -86,6 +86,7 @@ namespace lms::db
         static pointer					find(Session& session, const core::UUID& MBID);
         static pointer					find(Session& session, ArtistId id);
         static std::vector<pointer>		find(Session& session, std::string_view name);		// exact match on name field
+        static void                     find(Session& session, ArtistId& lastRetrievedArtist, std::size_t count, const std::function<void(const Artist::pointer&)>& func, MediaLibraryId library = {});
         static RangeResults<pointer>	find(Session& session, const FindParameters& parameters);
         static void					    find(Session& session, const FindParameters& parameters, std::function<void(const pointer&)> func);
         static RangeResults<ArtistId>	findIds(Session& session, const FindParameters& parameters);

src/libs/database/include/database/IdType.hpp

@@ -38,8 +38,7 @@ namespace lms::db
         std::string toString() const { assert(isValid()); return std::to_string(_id); }
 
         ValueType getValue() const { return _id; }
-
+        auto operator<=>(const IdType& other) const = default; \
-			auto operator<=>(const IdType& other) const = default;
 
     private:
         Wt::Dbo::dbo_default_traits::IdType _id{ Wt::Dbo::dbo_default_traits::invalidId() };
@@ -51,6 +50,7 @@ namespace lms::db
         { \
         public: \
             using IdType::IdType; \
+            auto operator<=>(const name& other) const = default; \
         };\
     } \
     namespace std \

src/libs/database/include/database/Release.hpp

@@ -122,6 +122,7 @@ namespace lms::db
         static pointer                  find(Session& session, const core::UUID& MBID);
         static std::vector<pointer>     find(Session& session, const std::string& name, const std::filesystem::path& releaseDirectory);
         static pointer                  find(Session& session, ReleaseId id);
+        static void                     find(Session& session, ReleaseId& lastRetrievedRelease, std::size_t count, const std::function<void(const Release::pointer&)>& func, MediaLibraryId library = {});
         static RangeResults<pointer>    find(Session& session, const FindParameters& parameters);
         static void                     find(Session& session, const FindParameters& parameters, std::function<void(const pointer&)> func);
         static RangeResults<ReleaseId>  findIds(Session& session, const FindParameters& parameters);

src/libs/database/test/Artist.cpp

@@ -77,6 +77,96 @@ namespace lms::db::tests
         }
     }
 
+    TEST_F(DatabaseFixture, Artist_findByRangedIdBased)
+    {
+        ScopedTrack track1{ session, "MyTrackFile1" };
+        ScopedTrack track2{ session, "MyTrackFile2" };
+        ScopedTrack track3{ session, "MyTrackFile3" };
+        ScopedArtist artist1{ session, "MyArtist1" };
+        ScopedArtist artist2{ session, "MyArtist2" };
+        ScopedArtist artist3{ session, "MyArtist3" };
+        ScopedMediaLibrary library{ session };
+        ScopedMediaLibrary otherLibrary{ session };
+
+        {
+            auto transaction{ session.createWriteTransaction() };
+            track2.get().modify()->setMediaLibrary(library.get());
+            TrackArtistLink::create(session, track1.get(), artist1.get(), TrackArtistLinkType::Artist);
+            TrackArtistLink::create(session, track2.get(), artist2.get(), TrackArtistLinkType::Artist);
+            TrackArtistLink::create(session, track3.get(), artist3.get(), TrackArtistLinkType::Artist);
+        }
+
+        {
+            auto transaction{ session.createReadTransaction() };
+
+            ArtistId lastRetrievedId;
+            std::vector<Artist::pointer> visitedArtists;
+            Artist::find(session, lastRetrievedId, 10, [&](const Artist::pointer& artist)
+                {
+                    visitedArtists.push_back(artist);
+                });
+            ASSERT_EQ(visitedArtists.size(), 3);
+            EXPECT_EQ(visitedArtists[0]->getId(), artist1.getId());
+            EXPECT_EQ(visitedArtists[1]->getId(), artist2.getId());
+            EXPECT_EQ(visitedArtists[2]->getId(), artist3.getId());
+            EXPECT_EQ(lastRetrievedId, artist3.getId());
+        }
+
+        {
+            auto transaction{ session.createReadTransaction() };
+
+            ArtistId lastRetrievedId{ artist1.getId() };
+            std::vector<Artist::pointer> visitedArtists;
+            Artist::find(session, lastRetrievedId, 1, [&](const Artist::pointer& artist)
+                {
+                    visitedArtists.push_back(artist);
+                });
+            ASSERT_EQ(visitedArtists.size(), 1);
+            EXPECT_EQ(visitedArtists[0]->getId(), artist2.getId());
+            EXPECT_EQ(lastRetrievedId, artist2.getId());
+        }
+
+        {
+            auto transaction{ session.createReadTransaction() };
+
+            ArtistId lastRetrievedId{ artist1.getId() };
+            std::vector<Artist::pointer> visitedArtists;
+            Artist::find(session, lastRetrievedId, 0, [&](const Artist::pointer& artist)
+                {
+                    visitedArtists.push_back(artist);
+                });
+            ASSERT_EQ(visitedArtists.size(), 0);
+            EXPECT_EQ(lastRetrievedId, artist1.getId());
+        }
+
+        {
+            auto transaction{ session.createReadTransaction() };
+
+            ArtistId lastRetrievedId;
+            std::vector<Artist::pointer> visitedArtists;
+            Artist::find(session, lastRetrievedId, 10, [&](const Artist::pointer& artist)
+                {
+                    visitedArtists.push_back(artist);
+                }, otherLibrary.getId());
+            ASSERT_EQ(visitedArtists.size(), 0);
+            EXPECT_EQ(lastRetrievedId, ArtistId{});
+        }
+
+        {
+            auto transaction{ session.createReadTransaction() };
+
+            ArtistId lastRetrievedId;
+            std::vector<Artist::pointer> visitedArtists;
+            Artist::find(session, lastRetrievedId, 10, [&](const Artist::pointer& artist)
+                {
+                    visitedArtists.push_back(artist);
+                }, library.getId());
+            ASSERT_EQ(visitedArtists.size(), 1);
+            EXPECT_EQ(visitedArtists[0]->getId(), artist2.getId());
+            EXPECT_EQ(lastRetrievedId, artist2.getId());
+        }
+    }
+
     TEST_F(DatabaseFixture, MultipleArtists)
     {
         {

src/libs/database/test/Release.cpp

@@ -74,6 +74,96 @@ namespace lms::db::tests
         }
     }
 
+    TEST_F(DatabaseFixture, Release_findByRangedIdBased)
+    {
+        ScopedTrack track1{ session, "MyTrackFile1" };
+        ScopedTrack track2{ session, "MyTrackFile2" };
+        ScopedTrack track3{ session, "MyTrackFile3" };
+        ScopedRelease release1{ session, "MyRelease1" };
+        ScopedRelease release2{ session, "MyRelease2" };
+        ScopedRelease release3{ session, "MyRelease3" };
+        ScopedMediaLibrary library{ session };
+        ScopedMediaLibrary otherLibrary{ session };
+
+        {
+            auto transaction{ session.createWriteTransaction() };
+            track2.get().modify()->setMediaLibrary(library.get());
+            track1.get().modify()->setRelease(release1.get());
+            track2.get().modify()->setRelease(release2.get());
+            track3.get().modify()->setRelease(release3.get());
+        }
+
+        {
+            auto transaction{ session.createReadTransaction() };
+
+            ReleaseId lastRetrievedId;
+            std::vector<Release::pointer> visitedReleases;
+            Release::find(session, lastRetrievedId, 10, [&](const Release::pointer& release)
+                {
+                    visitedReleases.push_back(release);
+                });
+            ASSERT_EQ(visitedReleases.size(), 3);
+            EXPECT_EQ(visitedReleases[0]->getId(), release1.getId());
+            EXPECT_EQ(visitedReleases[1]->getId(), release2.getId());
+            EXPECT_EQ(visitedReleases[2]->getId(), release3.getId());
+            EXPECT_EQ(lastRetrievedId, release3.getId());
+        }
+
+        {
+            auto transaction{ session.createReadTransaction() };
+
+            ReleaseId lastRetrievedId{ release1.getId() };
+            std::vector<Release::pointer> visitedReleases;
+            Release::find(session, lastRetrievedId, 1, [&](const Release::pointer& release)
+                {
+                    visitedReleases.push_back(release);
+                });
+            ASSERT_EQ(visitedReleases.size(), 1);
+            EXPECT_EQ(visitedReleases[0]->getId(), release2.getId());
+            EXPECT_EQ(lastRetrievedId, release2.getId());
+        }
+
+        {
+            auto transaction{ session.createReadTransaction() };
+
+            ReleaseId lastRetrievedId{ release1.getId() };
+            std::vector<Release::pointer> visitedReleases;
+            Release::find(session, lastRetrievedId, 0, [&](const Release::pointer& release)
+                {
+                    visitedReleases.push_back(release);
+                });
+            ASSERT_EQ(visitedReleases.size(), 0);
+            EXPECT_EQ(lastRetrievedId, release1.getId());
+        }
+
+        {
+            auto transaction{ session.createReadTransaction() };
+
+            ReleaseId lastRetrievedId;
+            std::vector<Release::pointer> visitedReleases;
+            Release::find(session, lastRetrievedId, 10, [&](const Release::pointer& release)
+                {
+                    visitedReleases.push_back(release);
+                }, otherLibrary.getId());
+            ASSERT_EQ(visitedReleases.size(), 0);
+            EXPECT_EQ(lastRetrievedId, ReleaseId{});
+        }
+
+        {
+            auto transaction{ session.createReadTransaction() };
+
+            ReleaseId lastRetrievedId;
+            std::vector<Release::pointer> visitedReleases;
+            Release::find(session, lastRetrievedId, 10, [&](const Release::pointer& release)
+                {
+                    visitedReleases.push_back(release);
+                }, library.getId());
+            ASSERT_EQ(visitedReleases.size(), 1);
+            EXPECT_EQ(visitedReleases[0]->getId(), release2.getId());
+            EXPECT_EQ(lastRetrievedId, release2.getId());
+        }
+    }
+
     TEST_F(DatabaseFixture, Release_singleTrack)
     {
         ScopedRelease release{ session, "MyRelease" };

src/libs/metadata/impl/TagLibTagReader.cpp

@@ -19,6 +19,8 @@
 
 #include "TagLibTagReader.hpp"
 
+#include <unordered_map>
+
 #include <taglib/apetag.h>
 #include <taglib/asffile.h>
 #include <taglib/id3v2tag.h>

src/libs/subsonic/impl/entrypoints/Searching.cpp

@@ -23,6 +23,7 @@
 #include <mutex>
 #include <map>
 
+#include "core/Random.hpp"
 #include "database/Artist.hpp"
 #include "database/Release.hpp"
 #include "database/Session.hpp"
@@ -59,7 +60,6 @@ namespace lms::api::subsonic
 
             ObjectId extractLastRetrievedObjectId(const ScanInfo& info);
             void setObjectId(const ScanInfo& info, ObjectId lastRetrievedId);
-            void cleanOutdatedScanEntries();
 
         private:
             using ClockType = std::chrono::steady_clock;
@@ -70,6 +70,7 @@ namespace lms::api::subsonic
                 ObjectId objectId;
             };
 
+            static constexpr std::size_t maxScanCount{ 50 };
             static constexpr ClockType::duration maxEntryDuration{ std::chrono::seconds{30} };
 
             std::mutex _mutex;
@@ -81,76 +82,51 @@ namespace lms::api::subsonic
         {
             ObjectId res;
 
+            {
                 const std::scoped_lock lock{ _mutex };
+
                 auto it{ _ongoingScans.find(scanInfo) };
                 if (it != _ongoingScans.end())
                 {
                     res = it->second.objectId;
                     _ongoingScans.erase(it);
                 }
+            }
 
             return res;
         }
 
         template<typename ObjectId>
         void ScanTracker<ObjectId>::setObjectId(const ScanInfo& scanInfo, ObjectId lastRetrievedId)
-        {
-            const std::scoped_lock lock{ _mutex };
-            _ongoingScans[scanInfo] = { ClockType::now(), lastRetrievedId };
-        }
-
-        template<typename ObjectId>
-        void ScanTracker<ObjectId>::cleanOutdatedScanEntries()
         {
             const ClockType::time_point now{ ClockType::now() };
 
             const std::scoped_lock lock{ _mutex };
+
+            // clean outdated scan entries; we do this to not have to flush everything each time we add/remove entries in the database
             std::erase_if(_ongoingScans, [&](const auto& entry) { return now > entry.second.timePoint + maxEntryDuration; });
-        }
+            // prevent the cache size from going out of control
+            if (_ongoingScans.size() == maxScanCount)
+                _ongoingScans.erase(core::random::pickRandom(_ongoingScans));
+
+            _ongoingScans[scanInfo] = { now, lastRetrievedId };
         }
 
-    namespace
+        void findRequestedArtists(RequestContext& context, bool id3, const std::vector<std::string_view>& keywords, MediaLibraryId mediaLibrary, const User::pointer& user, Response::Node& searchResultNode)
         {
-        Response handleSearchRequestCommon(RequestContext& context, bool id3)
+            static ScanTracker<ArtistId> currentScansInProgress;
-        {
-            // Mandatory params
-            const std::string queryString{ getMandatoryParameterAs<std::string>(context.parameters, "query") };
-            std::string_view query{ queryString };
 
-            // Optional params
             const std::size_t artistCount{ getParameterAs<std::size_t>(context.parameters, "artistCount").value_or(20) };
-            const std::size_t artistOffset{ getParameterAs<std::size_t>(context.parameters, "artistOffset").value_or(0) };
+            if (artistCount == 0)
-            const std::size_t albumCount{ getParameterAs<std::size_t>(context.parameters, "albumCount").value_or(20) };
+                return;
-            const std::size_t albumOffset{ getParameterAs<std::size_t>(context.parameters, "albumOffset").value_or(0) };
-            const std::size_t songCount{ getParameterAs<std::size_t>(context.parameters, "songCount").value_or(20) };
-            const std::size_t songOffset{ getParameterAs<std::size_t>(context.parameters, "songOffset").value_or(0) };
-            const MediaLibraryId mediaLibrary{ getParameterAs<MediaLibraryId>(context.parameters, "musicFolderId").value_or(MediaLibraryId{}) };
 
             if (artistCount > defaultMaxCountSize)
                 throw ParameterValueTooHighGenericError{ "artistCount", defaultMaxCountSize };
-            if (albumCount > defaultMaxCountSize)
-                throw ParameterValueTooHighGenericError{ "albumCount", defaultMaxCountSize };
-            if (songCount > defaultMaxCountSize)
-                throw ParameterValueTooHighGenericError{ "songCount", defaultMaxCountSize };
 
-            // Symfonium adds extra ""
+            const std::size_t artistOffset{ getParameterAs<std::size_t>(context.parameters, "artistOffset").value_or(0) };
-            if (context.clientInfo.name == "Symfonium")
-                query = core::stringUtils::stringTrim(query, "\"");
 
-            std::vector<std::string_view> keywords;
+            ArtistId lastRetrievedId;
-            if (!query.empty())
+            auto findArtists{ [&]
-                keywords = core::stringUtils::splitString(query, ' ');
-
-            Response response{ Response::createOkResponse(context.serverProtocolVersion) };
-            Response::Node& searchResult2Node{ response.createNode(id3 ? "searchResult3" : "searchResult2") };
-
-            auto transaction{ context.dbSession.createReadTransaction() };
-
-            User::pointer user{ User::find(context.dbSession, context.userId) };
-            if (!user)
-                throw UserNotAuthorizedError{};
-
-            if (artistCount > 0)
             {
                     Artist::FindParameters params;
                     params.setKeywords(keywords);
@@ -159,11 +135,63 @@ namespace lms::api::subsonic
 
                     Artist::find(context.dbSession, params, [&](const Artist::pointer& artist)
                         {
-                        searchResult2Node.addArrayChild("artist", createArtistNode(context, artist, user, id3));
+                            searchResultNode.addArrayChild("artist", createArtistNode(context, artist, user, id3));
+                            lastRetrievedId = artist->getId();
                         });
+                } };
+
+            if (!keywords.empty())
+            {
+                findArtists();
+            }
+            else
+            {
+                ScanTracker<ArtistId>::ScanInfo scanInfo
+                {
+                    .clientAddress = context.clientInfo.ipAddress,
+                    .clientName = context.clientInfo.name,
+                    .userName = context.clientInfo.user,
+                    .library = mediaLibrary,
+                    .offset = artistOffset
+                };
+
+                if (ArtistId cachedLastRetrievedId{ currentScansInProgress.extractLastRetrievedObjectId(scanInfo) }; cachedLastRetrievedId.isValid())
+                {
+                    Artist::find(context.dbSession, cachedLastRetrievedId, artistCount, [&](const Artist::pointer& artist)
+                        {
+                            searchResultNode.addArrayChild("artist", createArtistNode(context, artist, user, id3));
+                        }, mediaLibrary);
+                    lastRetrievedId = cachedLastRetrievedId;
+                }
+                else
+                {
+                    findArtists();
                 }
 
-            if (albumCount > 0)
+                if (lastRetrievedId.isValid())
+                {
+                    scanInfo.offset = artistOffset + artistCount;
+                    currentScansInProgress.setObjectId(scanInfo, lastRetrievedId);
+                }
+            }
+        }
+
+        void findRequestedAlbums(RequestContext& context, bool id3, const std::vector<std::string_view>& keywords, MediaLibraryId mediaLibrary, const User::pointer& user, Response::Node& searchResultNode)
+        {
+            static ScanTracker<ReleaseId> currentScansInProgress;
+
+            const std::size_t albumCount{ getParameterAs<std::size_t>(context.parameters, "albumCount").value_or(20) };
+            if (albumCount == 0)
+                return;
+
+            if (albumCount > defaultMaxCountSize)
+                throw ParameterValueTooHighGenericError{ "albumCount", defaultMaxCountSize };
+
+            const std::size_t albumOffset{ getParameterAs<std::size_t>(context.parameters, "albumOffset").value_or(0) };
+
+            ReleaseId lastRetrievedId;
+
+            auto findReleases{ [&]
             {
                 Release::FindParameters params;
                 params.setKeywords(keywords);
@@ -172,14 +200,59 @@ namespace lms::api::subsonic
 
                 Release::find(context.dbSession, params, [&](const Release::pointer& release)
                     {
-                        searchResult2Node.addArrayChild("album", createAlbumNode(context, release, user, id3));
+                        searchResultNode.addArrayChild("album", createAlbumNode(context, release, user, id3));
+                        lastRetrievedId = release->getId();
                     });
+            } };
+
+            if (!keywords.empty())
+            {
+                findReleases();
+            }
+            else
+            {
+                ScanTracker<ReleaseId>::ScanInfo scanInfo
+                {
+                    .clientAddress = context.clientInfo.ipAddress,
+                    .clientName = context.clientInfo.name,
+                    .userName = context.clientInfo.user,
+                    .library = mediaLibrary,
+                    .offset = albumOffset
+                };
+
+                if (ReleaseId cachedLastRetrievedId{ currentScansInProgress.extractLastRetrievedObjectId(scanInfo) }; cachedLastRetrievedId.isValid())
+                {
+                    Release::find(context.dbSession, cachedLastRetrievedId, albumCount, [&](const Release::pointer& release)
+                        {
+                            searchResultNode.addArrayChild("album", createAlbumNode(context, release, user, id3));
+                        }, mediaLibrary);
+                    lastRetrievedId = cachedLastRetrievedId;
+                }
+                else
+                {
+                    findReleases();
                 }
 
-            if (songCount > 0)
+                if (lastRetrievedId.isValid())
+                {
+                    scanInfo.offset = albumOffset + albumCount;
+                    currentScansInProgress.setObjectId(scanInfo, lastRetrievedId);
+                }
+            }
+        }
+
+        void findRequestedTracks(RequestContext& context, const std::vector<std::string_view>& keywords, MediaLibraryId mediaLibrary, const User::pointer& user, Response::Node& searchResultNode)
         {
             static ScanTracker<TrackId> currentScansInProgress;
-                currentScansInProgress.cleanOutdatedScanEntries();
+
+            const std::size_t songCount{ getParameterAs<std::size_t>(context.parameters, "songCount").value_or(20) };
+            if (songCount == 0)
+                return;
+
+            if (songCount > defaultMaxCountSize)
+                throw ParameterValueTooHighGenericError{ "songCount", defaultMaxCountSize };
+
+            const std::size_t songOffset{ getParameterAs<std::size_t>(context.parameters, "songOffset").value_or(0) };
 
             TrackId lastRetrievedId;
 
@@ -192,7 +265,7 @@ namespace lms::api::subsonic
 
                 Track::find(context.dbSession, params, [&](const Track::pointer& track)
                     {
-                            searchResult2Node.addArrayChild("song", createSongNode(context, track, user));
+                        searchResultNode.addArrayChild("song", createSongNode(context, track, user));
                         lastRetrievedId = track->getId();
                     });
             } };
@@ -216,7 +289,7 @@ namespace lms::api::subsonic
                 {
                     Track::find(context.dbSession, cachedLastRetrievedId, songCount, [&](const Track::pointer& track)
                         {
-                                searchResult2Node.addArrayChild("song", createSongNode(context, track, user));
+                            searchResultNode.addArrayChild("song", createSongNode(context, track, user));
                         }, mediaLibrary);
                     lastRetrievedId = cachedLastRetrievedId;
                 }
@@ -232,6 +305,39 @@ namespace lms::api::subsonic
                 }
             }
         }
+    }
+
+    namespace
+    {
+        Response handleSearchRequestCommon(RequestContext& context, bool id3)
+        {
+            // Mandatory params
+            const std::string queryString{ getMandatoryParameterAs<std::string>(context.parameters, "query") };
+            std::string_view query{ queryString };
+
+            // Optional params
+            const MediaLibraryId mediaLibrary{ getParameterAs<MediaLibraryId>(context.parameters, "musicFolderId").value_or(MediaLibraryId{}) };
+
+            // Symfonium adds extra ""
+            if (context.clientInfo.name == "Symfonium")
+                query = core::stringUtils::stringTrim(query, "\"");
+
+            std::vector<std::string_view> keywords;
+            if (!query.empty())
+                keywords = core::stringUtils::splitString(query, ' ');
+
+            Response response{ Response::createOkResponse(context.serverProtocolVersion) };
+            Response::Node& searchResultNode{ response.createNode(id3 ? "searchResult3" : "searchResult2") };
+
+            auto transaction{ context.dbSession.createReadTransaction() };
+
+            User::pointer user{ User::find(context.dbSession, context.userId) };
+            if (!user)
+                throw UserNotAuthorizedError{};
+
+            findRequestedArtists(context, id3, keywords, mediaLibrary, user, searchResultNode);
+            findRequestedAlbums(context, id3, keywords, mediaLibrary, user, searchResultNode);
+            findRequestedTracks(context, keywords, mediaLibrary, user, searchResultNode);
 
             return response;
         }