From 644903bc02d95ca40170aefb7c0a2f5180bc57d1 Mon Sep 17 00:00:00 2001 From: emeric Date: Mon, 31 Jan 2022 13:13:08 +0100 Subject: [PATCH] Fixed bad object id resolution in random view modes (IDs are cached and may be removed by the scanner) --- src/lms/ui/explore/ArtistsView.cpp | 4 ++-- src/lms/ui/explore/ReleasesView.cpp | 4 ++-- src/lms/ui/explore/TracksView.cpp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/lms/ui/explore/ArtistsView.cpp b/src/lms/ui/explore/ArtistsView.cpp index 34fc0966..d7ae20ed 100644 --- a/src/lms/ui/explore/ArtistsView.cpp +++ b/src/lms/ui/explore/ArtistsView.cpp @@ -157,8 +157,8 @@ Artists::addSome() const auto artistIds {_artistCollector.get(Range {static_cast(_container->getCount()), _batchSize})}; for (const ArtistId artistId : artistIds.results) { - const auto artist {Artist::find(LmsApp->getDbSession(), artistId)}; - _container->add(ArtistListHelpers::createEntry(artist)); + if (const auto artist {Artist::find(LmsApp->getDbSession(), artistId)}) + _container->add(ArtistListHelpers::createEntry(artist)); } _container->setHasMore(artistIds.moreResults); diff --git a/src/lms/ui/explore/ReleasesView.cpp b/src/lms/ui/explore/ReleasesView.cpp index 6fc358da..6ac2637b 100644 --- a/src/lms/ui/explore/ReleasesView.cpp +++ b/src/lms/ui/explore/ReleasesView.cpp @@ -121,8 +121,8 @@ Releases::addSome() const auto releaseIds {_releaseCollector.get(Range {static_cast(_container->getCount()), _batchSize})}; for (const ReleaseId releaseId : releaseIds.results) { - const Release::pointer release {Release::find(LmsApp->getDbSession(), releaseId)}; - _container->add(ReleaseListHelpers::createEntry(release)); + if (const Release::pointer release {Release::find(LmsApp->getDbSession(), releaseId)}) + _container->add(ReleaseListHelpers::createEntry(release)); } _container->setHasMore(releaseIds.moreResults); diff --git a/src/lms/ui/explore/TracksView.cpp b/src/lms/ui/explore/TracksView.cpp index c93e9a18..1b602ca8 100644 --- a/src/lms/ui/explore/TracksView.cpp +++ b/src/lms/ui/explore/TracksView.cpp @@ -125,8 +125,8 @@ Tracks::addSome() for (const TrackId trackId : trackIds.results) { - const Track::pointer track {Track::find(LmsApp->getDbSession(), trackId)}; - _container->add(TrackListHelpers::createEntry(track, tracksAction)); + if (const Track::pointer track {Track::find(LmsApp->getDbSession(), trackId)}) + _container->add(TrackListHelpers::createEntry(track, tracksAction)); } _container->setHasMore(trackIds.moreResults);