From 68d45a500188dd4fd406e4229476a66fda7fc52e Mon Sep 17 00:00:00 2001 From: emeric Date: Sat, 8 Jun 2024 14:01:47 +0200 Subject: [PATCH] Improved unit test --- src/libs/metadata/test/Parser.cpp | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/libs/metadata/test/Parser.cpp b/src/libs/metadata/test/Parser.cpp index b5b6731b..38f0d3d3 100644 --- a/src/libs/metadata/test/Parser.cpp +++ b/src/libs/metadata/test/Parser.cpp @@ -229,22 +229,24 @@ namespace lms::metadata { const TestTagReader testTags{ { - { TagType::Genre, { "Genre1; Genre2" } }, - { TagType::Language, { " Lang1 ; Lang2 ; " } }, + { TagType::Genre, { "Genre1 ; Genre2" } }, + { TagType::Language, { " Lang1/Lang2 / Lang3" } }, { TagType::Artist, { " This / is ; One Artist \\ Other Artist " } }, } }; Parser parser; - static_cast(parser).setDefaultTagDelimiters(std::vector{ " ; " }); - static_cast(parser).setArtistTagDelimiters(std::vector{ " \\ ", " / " }); + static_cast(parser).setDefaultTagDelimiters(std::vector{ " ; ", "/" }); + static_cast(parser).setArtistTagDelimiters(std::vector{ " \\ ", " / " }); // The first delimiter found will be used std::unique_ptr track{ parser.parse(testTags) }; - ASSERT_EQ(track->genres.size(), 1); - EXPECT_EQ(track->genres[0], "Genre1; Genre2"); - ASSERT_EQ(track->languages.size(), 2); + ASSERT_EQ(track->genres.size(), 2); + EXPECT_EQ(track->genres[0], "Genre1"); + EXPECT_EQ(track->genres[1], "Genre2"); + ASSERT_EQ(track->languages.size(), 3); EXPECT_EQ(track->languages[0], "Lang1"); EXPECT_EQ(track->languages[1], "Lang2"); + EXPECT_EQ(track->languages[2], "Lang3"); ASSERT_EQ(track->artists.size(), 2); EXPECT_EQ(track->artists[0].name, "This / is ; One Artist"); EXPECT_EQ(track->artists[1].name, "Other Artist");