owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed useless join

Browse Source
This commit is contained in:
emeric
2024-04-16 14:28:30 +02:00
parent 7ecaa16b8e
commit 78dd0302d0
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/database/impl/Release.cpp
+6 -5
View File
@@ -90,11 +90,13 @@ namespace lms::db
if (params.artist.isValid() if (params.artist.isValid()
|| params.sortMethod == ReleaseSortMethod::ArtistNameThenName) || params.sortMethod == ReleaseSortMethod::ArtistNameThenName)
{ {
query.join("artist a ON a.id = t_a_l.artist_id") query.join("track_artist_link t_a_l ON t_a_l.track_id = t.id");
.join("track_artist_link t_a_l ON t_a_l.track_id = t.id");
if (params.artist.isValid()) if (params.artist.isValid())
query.where("a.id = ?").bind(params.artist); query.where("t_a_l.artist_id = ?").bind(params.artist);
if (params.sortMethod == ReleaseSortMethod::ArtistNameThenName)
query.join("artist a ON a.id = t_a_l.artist_id");
if (!params.trackArtistLinkTypes.empty()) if (!params.trackArtistLinkTypes.empty())
{ {
@@ -117,10 +119,9 @@ namespace lms::db
{ {
std::ostringstream oss; std::ostringstream oss;
oss << "r.id NOT IN (SELECT DISTINCT r.id FROM release r" oss << "r.id NOT IN (SELECT DISTINCT r.id FROM release r"
" INNER JOIN artist a ON a.id = t_a_l.artist_id"
" INNER JOIN track_artist_link t_a_l ON t_a_l.track_id = t.id" " INNER JOIN track_artist_link t_a_l ON t_a_l.track_id = t.id"
" INNER JOIN track t ON t.release_id = r.id" " INNER JOIN track t ON t.release_id = r.id"
" WHERE (a.id = ? AND ("; " WHERE (t_a_l.artist_id = ? AND (";
query.bind(params.artist); query.bind(params.artist);