From 88c85291bc5ef19109a6a0db5e13ee626d29ed23 Mon Sep 17 00:00:00 2001 From: emeric Date: Wed, 3 Jun 2026 22:51:06 +0200 Subject: [PATCH] Remove track artist recommendations for now --- .../impl/audio-similarity/AudioSimilarityEngine.impl.hpp | 9 --------- .../recommendation/impl/clusters/ClustersEngine.cpp | 7 ------- .../impl/track-selection-constraints/TrackMetadata.hpp | 2 +- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/src/libs/services/recommendation/impl/audio-similarity/AudioSimilarityEngine.impl.hpp b/src/libs/services/recommendation/impl/audio-similarity/AudioSimilarityEngine.impl.hpp index 5440cf5b..550d2871 100644 --- a/src/libs/services/recommendation/impl/audio-similarity/AudioSimilarityEngine.impl.hpp +++ b/src/libs/services/recommendation/impl/audio-similarity/AudioSimilarityEngine.impl.hpp @@ -614,15 +614,6 @@ namespace lms::recommendation db::Artist::find(session, db::Artist::FindParameters{}, [&](const db::Artist::pointer& artist) { std::unordered_set artistTrackIds; - // Track-level artists - { - db::Track::FindParameters params; - params.setArtist(artist->getId(), { db::TrackArtistLinkType::Artist }); - for (const db::TrackId trackId : db::Track::findIds(session, params).results) - artistTrackIds.insert(trackId); - } - - // Album-level artists { db::Release::FindParameters params; params.setArtist(artist->getId()); diff --git a/src/libs/services/recommendation/impl/clusters/ClustersEngine.cpp b/src/libs/services/recommendation/impl/clusters/ClustersEngine.cpp index 64c38db2..3da0a3fc 100644 --- a/src/libs/services/recommendation/impl/clusters/ClustersEngine.cpp +++ b/src/libs/services/recommendation/impl/clusters/ClustersEngine.cpp @@ -144,13 +144,6 @@ namespace lms::recommendation db::Artist::find(session, db::Artist::FindParameters{}, [&](const db::Artist::pointer& artist) { std::unordered_set artistTrackIds; - { - db::Track::FindParameters params; - params.setArtist(artist->getId(), { db::TrackArtistLinkType::Artist }); - for (const db::TrackId trackId : db::Track::findIds(session, params).results) - artistTrackIds.insert(trackId); - } - { db::Release::FindParameters params; params.setArtist(artist->getId()); diff --git a/src/libs/services/recommendation/impl/track-selection-constraints/TrackMetadata.hpp b/src/libs/services/recommendation/impl/track-selection-constraints/TrackMetadata.hpp index 9dff70a7..d2a89b43 100644 --- a/src/libs/services/recommendation/impl/track-selection-constraints/TrackMetadata.hpp +++ b/src/libs/services/recommendation/impl/track-selection-constraints/TrackMetadata.hpp @@ -31,7 +31,7 @@ namespace lms::recommendation struct TrackMetadata { db::ReleaseId releaseId; // invalid if track has no release - std::vector artistIds; // sorted; track-level + album-level artists + std::vector artistIds; // sorted; album artists only // Future: db::MediaLibraryId mediaLibraryId; };