owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed lgtm alert

Browse Source
This commit is contained in:
emeric
2022-05-28 18:52:30 +02:00
parent d3c117ebb1
commit 8d0bbd0807
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/services/recommendation/impl/features/FeaturesEngine.cpp
+3 -3
View File
@@ -213,7 +213,7 @@ FeaturesEngine::loadFromTraining(const TrainSettings& trainSettings, const Progr
} }
void void
FeaturesEngine::loadFromCache(FeaturesEngineCache cache) FeaturesEngine::loadFromCache(FeaturesEngineCache&& cache)
{ {
LMS_LOG(RECOMMENDATION, INFO) << "Constructing features classifier from cache..."; LMS_LOG(RECOMMENDATION, INFO) << "Constructing features classifier from cache...";
@@ -341,9 +341,9 @@ FeaturesEngine::load(bool forceReload, const ProgressCallback& progressCallback)
{ {
FeaturesEngineCache::invalidate(); FeaturesEngineCache::invalidate();
} }
else if (const std::optional<FeaturesEngineCache> cache {FeaturesEngineCache::read()}) else if (std::optional<FeaturesEngineCache> cache {FeaturesEngineCache::read()})
{ {
loadFromCache(*cache); loadFromCache(std::move(*cache));
return; return;
} }
src/libs/services/recommendation/impl/features/FeaturesEngine.hpp
+1 -1
View File
@@ -63,7 +63,7 @@ class FeaturesEngine : public IEngine
ReleaseContainer getSimilarReleases(Database::ReleaseId releaseId, std::size_t maxCount) const override; ReleaseContainer getSimilarReleases(Database::ReleaseId releaseId, std::size_t maxCount) const override;
ArtistContainer getSimilarArtists(Database::ArtistId artistId, EnumSet<Database::TrackArtistLinkType> linkTypes, std::size_t maxCount) const override; ArtistContainer getSimilarArtists(Database::ArtistId artistId, EnumSet<Database::TrackArtistLinkType> linkTypes, std::size_t maxCount) const override;
void loadFromCache(FeaturesEngineCache cache); void loadFromCache(FeaturesEngineCache&& cache);
// Use training (may be very slow) // Use training (may be very slow)
struct TrainSettings struct TrainSettings