From 8de3e2f01e07856d1c18dddc1acb3fae96dec020 Mon Sep 17 00:00:00 2001 From: emeric Date: Wed, 5 Aug 2015 00:03:54 +0200 Subject: [PATCH] [Transcode] Better close herited fds --- src/transcode/AvConvTranscoder.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/transcode/AvConvTranscoder.cpp b/src/transcode/AvConvTranscoder.cpp index 8d50d685..70b056fa 100644 --- a/src/transcode/AvConvTranscoder.cpp +++ b/src/transcode/AvConvTranscoder.cpp @@ -157,15 +157,12 @@ AvConvTranscoder::AvConvTranscoder(const Parameters& parameters) // See boost process FAQ { boost::lock_guard lock(_mutex); - std::vector ranges = { 3, 1024 }; // fd range to be closed _child = std::make_shared( boost::process::execute( boost::process::initializers::run_exe(_avConvPath), boost::process::initializers::set_cmd_line(oss.str()), boost::process::initializers::bind_stdout(sink), - boost::process::initializers::close_fd(STDIN_FILENO), - boost::process::initializers::close_fd(STDERR_FILENO), - boost::process::initializers::close_fds(ranges) + boost::process::initializers::close_fds_if([](int fd) { return fd != STDOUT_FILENO;}) ) ); }