owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

First consider album artists when multiple names are used for the same artist mbid and no artist info is present, ref #731

Browse Source
This commit is contained in:
emeric
2025-11-16 11:14:20 +01:00
parent 51bd4c75ac
commit ab898b697c
7 changed files with 137 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/database/test/TrackArtistLink.cpp
+53
View File
@@ -222,4 +222,57 @@ namespace lms::db::tests
EXPECT_EQ(links[1]->getArtistName(), "MyArtistOldName");
}
}
TEST_F(DatabaseFixture, TrackArtistLink_findWithMBIDMatched)
{
ScopedArtist artist{ session, "MyArtist", core::UUID::fromString("97d1fb6f-db09-4760-b0b3-816559bcb632") };
ScopedTrack track1{ session };
ScopedTrack track2{ session };
{
auto transaction{ session.createWriteTransaction() };
auto link1{ session.create<TrackArtistLink>(track1.get(), artist.get(), TrackArtistLinkType::Artist, false) };
auto link2{ session.create<TrackArtistLink>(track2.get(), artist.get(), TrackArtistLinkType::Artist, true) };
}
{
auto transaction{ session.createReadTransaction() };
TrackArtistLink::FindParameters params;
std::vector<TrackArtistLink::pointer> links;
TrackArtistLink::find(session, params, [&](const TrackArtistLink::pointer& link) {
links.push_back(link);
});
ASSERT_EQ(links.size(), 2);
}
{
auto transaction{ session.createReadTransaction() };
TrackArtistLink::FindParameters params;
params.setMBIDMatched(false);
std::vector<TrackArtistLink::pointer> links;
TrackArtistLink::find(session, params, [&](const TrackArtistLink::pointer& link) {
links.push_back(link);
});
ASSERT_EQ(links.size(), 1);
EXPECT_EQ(links[0]->getTrack()->getId(), track1.getId());
}
{
auto transaction{ session.createReadTransaction() };
TrackArtistLink::FindParameters params;
params.setMBIDMatched(true);
std::vector<TrackArtistLink::pointer> links;
TrackArtistLink::find(session, params, [&](const TrackArtistLink::pointer& link) {
links.push_back(link);
});
ASSERT_EQ(links.size(), 1);
EXPECT_EQ(links[0]->getTrack()->getId(), track2.getId());
}
}
} // namespace lms::db::tests