Various build fixes, ref #802

src/libs/subsonic/impl/endpoints/MediaRetrieval.cpp

@@ -52,7 +52,7 @@ namespace lms::api::subsonic
     {
         struct OutputFormat
         {
-            std::string name;
+            std::string_view name;
             core::media::Container container;
             core::media::Codec codec;
         };

src/libs/subsonic/impl/endpoints/Transcoding.hpp

@@ -26,7 +26,7 @@
 
 namespace lms::api::subsonic
 {
-    struct RequestContext;
+    class RequestContext;
 
     Response handleGetTranscodeDecision(RequestContext& context);
     void handleGetTranscodeStream(RequestContext& context, const Wt::Http::Request& request, Wt::Http::Response& response);

src/libs/subsonic/impl/endpoints/transcoding/TranscodeDecisionTracker.hpp

@@ -43,6 +43,13 @@ namespace lms::api::subsonic
             Clock::time_point addedTimePoint;
             AudioFileId audioFileId;
             StreamDetails targetStreamInfo;
+
+            Entry(Clock::time_point _addedTimePoint, AudioFileId _audioFileId, const StreamDetails& _targetStreamInfo)
+                : addedTimePoint{ _addedTimePoint }
+                , audioFileId{ _audioFileId }
+                , targetStreamInfo{ _targetStreamInfo }
+            {
+            }
         };
 
         virtual core::UUID add(AudioFileId audioFileId, const StreamDetails& targetStreamInfo) = 0;

src/libs/subsonic/impl/payloads/ClientInfo.cpp

@@ -26,6 +26,7 @@
 #include <Wt/Json/Parser.h>
 
 #include "core/String.hpp"
+#include "core/Utils.hpp"
 
 #include "SubsonicResponse.hpp"
 
@@ -61,7 +62,7 @@ namespace lms::api::subsonic
                 }
                 else
                 {
-                    static_assert(false, "Unhandled type");
+                    static_assert(core::utils::dependent_false_v<T>, "Unhandled type");
                 }
 
                 return static_cast<T>(value);
@@ -105,7 +106,7 @@ namespace lms::api::subsonic
                     }
                     else
                     {
-                        static_assert(false, "Unhandled type");
+                        static_assert(core::utils::dependent_false_v<T>, "Unhandled type");
                     }
 
                     res.emplace_back(static_cast<T>(item));