From bedf97276975abb898e764d4dcf6f07f788da160 Mon Sep 17 00:00:00 2001 From: emeric Date: Sat, 8 Mar 2025 13:44:56 +0100 Subject: [PATCH] Minor cleanup --- src/lms/ui/explore/ReleaseView.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lms/ui/explore/ReleaseView.cpp b/src/lms/ui/explore/ReleaseView.cpp index f6f2a059..53041fb9 100644 --- a/src/lms/ui/explore/ReleaseView.cpp +++ b/src/lms/ui/explore/ReleaseView.cpp @@ -186,9 +186,9 @@ namespace lms::ui return core::stringUtils::readAs(wApp->internalPathNextPart("/release/")); } - void fillTrackArtistLinks(Wt::WTemplate* trackEntry, const db::Track::pointer& track) + void fillTrackArtistLinks(Wt::WTemplate* trackEntry, db::TrackId trackId) { - const std::map> artistsByRole{ TrackListHelpers::getArtistsByRole(track->getId()) }; + const std::map> artistsByRole{ TrackListHelpers::getArtistsByRole(trackId) }; if (artistsByRole.empty()) return; @@ -196,7 +196,7 @@ namespace lms::ui trackEntry->setCondition("if-has-artist-links", true); Wt::WContainerWidget* artistLinksContainer = trackEntry->bindNew("artist-links"); - for (auto& [role, artists] : artistsByRole) + for (const auto& [role, artists] : artistsByRole) { Wt::WTemplate* artistLinkEntry{ artistLinksContainer->addNew(Wt::WString::tr("Lms.Explore.Release.template.artist-links-entry")) }; artistLinkEntry->bindString("role", role, Wt::TextFormat::Plain); @@ -455,7 +455,7 @@ namespace lms::ui entry->bindWidget("artists-md", utils::createArtistDisplayNameWithAnchors(track->getArtistDisplayName(), artists)); } - fillTrackArtistLinks(entry, track); + fillTrackArtistLinks(entry, track->getId()); auto trackNumber{ track->getTrackNumber() }; if (trackNumber)