From 6f51f4255585f1b1108bc7ff33243cc8df8959f7 Mon Sep 17 00:00:00 2001 From: emeric Date: Thu, 8 Sep 2022 20:25:13 +0200 Subject: [PATCH 1/2] Fixed regression on playlists --- src/lms/ui/explore/TrackListView.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lms/ui/explore/TrackListView.cpp b/src/lms/ui/explore/TrackListView.cpp index 42ce624e..ced7f531 100644 --- a/src/lms/ui/explore/TrackListView.cpp +++ b/src/lms/ui/explore/TrackListView.cpp @@ -55,7 +55,7 @@ namespace UserInterface { TrackList::TrackList(Filters& filters, PlayQueueController& playQueueController) : Template {Wt::WString::tr("Lms.Explore.TrackList.template")} - , _filters {_filters} + , _filters {filters} , _playQueueController {playQueueController} { addFunction("tr", &Wt::WTemplate::Functions::tr); @@ -66,7 +66,7 @@ namespace UserInterface refreshView(); }); - filters.updated().connect([this] + _filters.updated().connect([this] { refreshView(); }); From 5d5ef5ed13550a1122d83eae10bc4dc7adb9613e Mon Sep 17 00:00:00 2001 From: emeric Date: Thu, 8 Sep 2022 20:37:01 +0200 Subject: [PATCH 2/2] Review from lgtm --- docroot/js/mediaplayer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docroot/js/mediaplayer.js b/docroot/js/mediaplayer.js index 32807cc0..2a588621 100644 --- a/docroot/js/mediaplayer.js +++ b/docroot/js/mediaplayer.js @@ -52,7 +52,7 @@ LMS.mediaplayer = function () { _audioCtx = new (window.AudioContext || window.webkitAudioContext)(); _gainNode = _audioCtx.createGain(); - source = _audioCtx.createMediaElementSource(_elems.audio); + let source = _audioCtx.createMediaElementSource(_elems.audio); source.connect(_gainNode); _gainNode.connect(_audioCtx.destination); _audioCtx.resume(); // not sure of this