Allow artist tags that can't have mbid (composer, lyricist, etc.) to fallback on artists which have mbid (track artists, release artists)

src/libs/database/impl/Artist.cpp

@@ -45,7 +45,10 @@ Artist::getByName(Session& session, const std::string& name)
 {
 	session.checkSharedLocked();
 
-	Wt::Dbo::collection<Artist::pointer> res = session.getDboSession().find<Artist>().where("name = ?").bind( std::string{name, 0, _maxNameLength} );
+	Wt::Dbo::collection<Artist::pointer> res = session.getDboSession().find<Artist>()
+		.where("name = ?").bind(std::string {name, 0, _maxNameLength})
+		.orderBy("LENGTH(mbid) DESC"); // put mbid entries first
+
 	return std::vector<Artist::pointer>(res.begin(), res.end());
 }
 

src/libs/database/impl/Session.cpp

@@ -40,7 +40,7 @@
 
 namespace Database {
 
-#define LMS_DATABASE_VERSION	27
+#define LMS_DATABASE_VERSION	28
 
 using Version = std::size_t;
 
@@ -284,6 +284,12 @@ CREATE TABLE "user_backup" (
 			// Just increment the scan version of the settings to make the next scheduled scan rescan everything
 			ScanSettings::get(*this).modify()->incScanVersion();
 		}
+		else if (version == 27)
+		{
+			// Composer, mixer, etc. support, now fallback on MBID tagged entries as there is no mean to provide MBID by tags for these kinf od artists
+			// Just increment the scan version of the settings to make the next scheduled scan rescan everything
+			ScanSettings::get(*this).modify()->incScanVersion();
+		}
 		else
 		{
 			LMS_LOG(DB, ERROR) << "Database version " << version << " cannot be handled using migration";

src/libs/database/include/database/ScanSettings.hpp

@@ -56,13 +56,13 @@ class ScanSettings : public Wt::Dbo::Dbo<ScanSettings>
 		static pointer get(Session& session);
 
 		// Getters
-		std::size_t getScanVersion() const { return _scanVersion; }
-		std::filesystem::path getMediaDirectory() const { return _mediaDirectory; }
-		Wt::WTime getUpdateStartTime() const { return _startTime; }
-		UpdatePeriod getUpdatePeriod() const { return _updatePeriod; }
+		std::size_t				getScanVersion() const { return _scanVersion; }
+		std::filesystem::path	getMediaDirectory() const { return _mediaDirectory; }
+		Wt::WTime				getUpdateStartTime() const { return _startTime; }
+		UpdatePeriod			getUpdatePeriod() const { return _updatePeriod; }
 		std::vector<Wt::Dbo::ptr<ClusterType>> getClusterTypes() const;
 		std::unordered_set<std::filesystem::path> getAudioFileExtensions() const;
-		RecommendationEngineType getRecommendationEngineType() const { return _recommendationEngineType; }
+		RecommendationEngineType	getRecommendationEngineType() const { return _recommendationEngineType; }
 
 		// Setters
 		void addAudioFileExtension(const std::filesystem::path& ext);