diff --git a/README.md b/README.md index d4344ff7..8534b2f0 100644 --- a/README.md +++ b/README.md @@ -52,7 +52,7 @@ The folder must follow a structure defined by Kodi, as detailed [here](https://k __Note__: If no name is provided in the `artist.nfo` file, the name of the containing folder is used. ### Filtering -It is possible to apply global filters on your collection using `genre`, `mood`, `grouping`, `language`, and by music library. More tags, including custom ones, can be added in the database administration settings. +It is possible to apply global filters on your collection using `genre`, `mood`, `grouping`, `language`, `codec`, and by music library. More tags, including custom ones, can be added in the database administration settings. __Note__: You can use the `lms-audioinfo` tool to get an idea of the tags parsed by _LMS_. diff --git a/src/lms/ui/explore/ArtistView.cpp b/src/lms/ui/explore/ArtistView.cpp index 58c0590a..297f58eb 100644 --- a/src/lms/ui/explore/ArtistView.cpp +++ b/src/lms/ui/explore/ArtistView.cpp @@ -80,11 +80,6 @@ namespace lms::ui refreshView(); }); - filters.updated().connect([this] { - _needForceRefresh = true; - refreshView(); - }); - refreshView(); } @@ -96,13 +91,12 @@ namespace lms::ui const auto artistId{ extractArtistIdFromInternalPath() }; // consider everything is up to date is the same artist is being rendered - if (!_needForceRefresh && artistId && *artistId == _artistId) + if (artistId && *artistId == _artistId) return; clear(); _artistId = {}; _trackContainer = nullptr; - _needForceRefresh = false; if (!artistId) throw ArtistNotFoundException{}; @@ -236,7 +230,6 @@ namespace lms::ui _releaseContainers.clear(); db::Release::FindParameters params; - params.setFilters(_filters.getDbFilters()); params.setArtist(_artistId, { db::TrackArtistLinkType::ReleaseArtist }, {}); params.setSortMethod(LmsApp->getUser()->getUIArtistReleaseSortMethod()); diff --git a/src/lms/ui/explore/ArtistView.hpp b/src/lms/ui/explore/ArtistView.hpp index a05f3de3..521cd03e 100644 --- a/src/lms/ui/explore/ArtistView.hpp +++ b/src/lms/ui/explore/ArtistView.hpp @@ -76,6 +76,5 @@ namespace lms::ui ReleaseContainer _appearsOnReleaseContainer{}; InfiniteScrollingContainer* _trackContainer{}; db::ArtistId _artistId{}; - bool _needForceRefresh{}; }; } // namespace lms::ui diff --git a/src/lms/ui/explore/ReleaseView.cpp b/src/lms/ui/explore/ReleaseView.cpp index 00f9f839..f2ea10dc 100644 --- a/src/lms/ui/explore/ReleaseView.cpp +++ b/src/lms/ui/explore/ReleaseView.cpp @@ -255,11 +255,6 @@ namespace lms::ui refreshView(); }); - _filters.updated().connect([this] { - _needForceRefresh = true; - refreshView(); - }); - refreshView(); } @@ -271,12 +266,11 @@ namespace lms::ui const auto releaseId{ extractReleaseIdFromInternalPath() }; // consider everything is up to date is the same release is being rendered - if (!_needForceRefresh && releaseId && *releaseId == _releaseId) + if (releaseId && *releaseId == _releaseId) return; clear(); _releaseId = {}; - _needForceRefresh = false; if (!releaseId) throw ReleaseNotFoundException{}; @@ -451,7 +445,6 @@ namespace lms::ui db::Track::FindParameters params; params.setMedium(medium->getId()); params.setSortMethod(db::TrackSortMethod::TrackNumber); - params.setFilters(_filters.getDbFilters()); // TODO: do we really want to hide all tracks when a release does not match the current label filter? db::Track::find(LmsApp->getDbSession(), params, [&](const db::Track::pointer& track) { const db::TrackId trackId{ track->getId() }; diff --git a/src/lms/ui/explore/ReleaseView.hpp b/src/lms/ui/explore/ReleaseView.hpp index 768fdbe6..76de048c 100644 --- a/src/lms/ui/explore/ReleaseView.hpp +++ b/src/lms/ui/explore/ReleaseView.hpp @@ -57,6 +57,5 @@ namespace lms::ui Filters& _filters; PlayQueueController& _playQueueController; db::ReleaseId _releaseId; - bool _needForceRefresh{}; }; } // namespace lms::ui