Codefactor review

approot/main.xml

@@ -35,7 +35,7 @@
 						${playqueue class="nav-link"}
 					</li>
 					<li class="nav-item">
-						${filters class="py-2 d-flex align-items-center"}
+						${filters class="nav-link d-flex align-items-center"}
 					</li>
 				</ul>
 				<div class="navbar-nav align-items-md-center mb-lg-0">

docroot/css/lms.css

@@ -89,7 +89,7 @@ body {
 .Lms-notification-container {
 	position: fixed;
 	bottom: 78px;
-	right: 0px;
+	right: 0;
 }
 
 .Lms-player {

src/libs/metadata/impl/AvFormatParser.cpp

@@ -226,7 +226,6 @@ AvFormatParser::parse(const std::filesystem::path& p, bool debug)
 					track.clusters[tag] = std::move(values);
 				}
 			}
-
 		}
 
 		track.artists = getArtists(metadataMap);

src/libs/metadata/impl/TagLibParser.cpp

@@ -148,7 +148,6 @@ getAlbum(const TagLib::PropertyMap& properties)
 void
 TagLibParser::processTag(Track& track, const std::string& tag, const TagLib::StringList& values, bool debug)
 {
-
 	if (debug)
 	{
 		std::vector<std::string> strs;

src/libs/som/include/som/DataNormalizer.hpp

@@ -30,7 +30,6 @@ namespace SOM
 class DataNormalizer
 {
 	public:
-
 		struct MinMax
 		{
 			InputVector::value_type min;

src/libs/som/include/som/InputVector.hpp

@@ -163,7 +163,6 @@ class InputVector
 		}
 
 	private:
-
 		friend class InputVector operator-(const InputVector& a, const InputVector& b)
 		{
 			if (!a.hasSameDimension(b.getNbDimensions()))

src/libs/som/include/som/Matrix.hpp

@@ -53,7 +53,6 @@ template <typename T>
 class Matrix
 {
 	public:
-
 		Matrix() = default;
 
 		Matrix(Coordinate width, Coordinate height)
@@ -109,7 +108,6 @@ class Matrix
 		}
 
 	private:
-
 		Coordinate		_width {};
 		Coordinate		_height {};
 		std::vector<T>	_values;

src/libs/som/include/som/Network.hpp

@@ -40,7 +40,6 @@ std::ostream& operator<<(std::ostream& os, const InputVector& a);
 class Network
 {
 	public:
-
 		// Init a network with random values
 		Network(Coordinate width, Coordinate height, std::size_t inputDimCount);
 

src/libs/subsonic/impl/SubsonicResponse.hpp

@@ -203,7 +203,6 @@ class Response
 				void addArrayChild(const std::string& key, Node node);
 
 			private:
-
 				void setVersionAttribute(ProtocolVersion version);
 
 				friend class Response;

src/libs/utils/impl/FileResourceHandler.hpp

@@ -28,7 +28,6 @@ class FileResourceHandler final : public IResourceHandler
 		FileResourceHandler(const std::filesystem::path& filePath);
 
 	private:
-
 		Wt::Http::ResponseContinuation* processRequest(const Wt::Http::Request& request, Wt::Http::Response& response) override;
 
 		static constexpr std::size_t _chunkSize {65536};

src/libs/utils/include/utils/IConfig.hpp

@@ -26,7 +26,6 @@
 class IConfig
 {
 	public:
-
 		virtual ~IConfig() = default;
 
 		// Default values are returned in case of setting not found

src/libs/utils/include/utils/UUID.hpp

@@ -28,7 +28,6 @@
 class UUID
 {
 	public:
-
 		static std::optional<UUID> fromString(std::string_view str);
 
 		std::string_view getAsString() const { return _value; }

src/libs/utils/include/utils/Zipper.hpp

@@ -40,7 +40,6 @@ namespace Zip
 	class Zipper
 	{
 		public:
-
 			Zipper(const std::map<std::string, std::filesystem::path>& files, const Wt::WDateTime& lastModifiedTime = {});
 
 			static constexpr SizeType minOutputBufferSize {64};

src/lms/ui/Auth.cpp

@@ -86,7 +86,6 @@ processAuthToken(const Wt::WEnvironment& env)
 class AuthModel : public Wt::WFormModel
 {
 	public:
-
 		// Associate each field with a unique string literal.
 		static const Field LoginNameField;
 		static const Field PasswordField;
@@ -160,7 +159,6 @@ class AuthModel : public Wt::WFormModel
 		std::optional<Database::UserId> getUserId() const { return _userId; }
 
 	private:
-
 		std::optional<Database::UserId> _userId;
 };
 
@@ -168,7 +166,6 @@ const AuthModel::Field AuthModel::LoginNameField {"login-name"};
 const AuthModel::Field AuthModel::PasswordField {"password"};
 const AuthModel::Field AuthModel::RememberMeField {"remember-me"};
 
-
 Auth::Auth()
 : Wt::WTemplateFormView {Wt::WString::tr("Lms.Auth.template")}
 {
@@ -217,7 +214,6 @@ Auth::Auth()
 	loginBtn->clicked().connect(this, processAuth);
 
 	updateView(model.get());
-
 }
 
 } // namespace UserInterface

src/lms/ui/LmsApplication.hpp

@@ -52,7 +52,6 @@ class ModalManager;
 class LmsApplication : public Wt::WApplication
 {
 	public:
-
 		LmsApplication(const Wt::WEnvironment& env, Database::Db& db, LmsApplicationManager& appManager, std::optional<Database::UserId> userId = std::nullopt);
 		~LmsApplication();
 

src/lms/ui/SettingsView.cpp

@@ -187,7 +187,6 @@ class SettingsModel : public Wt::WFormModel
 			{
 				_authPasswordService->setPassword(user->getId(), valueText(PasswordField).toUTF8());
 			}
-
 		}
 
 		void loadData()

src/lms/ui/admin/DatabaseSettingsView.cpp

@@ -143,7 +143,6 @@ class DatabaseSettingsModel : public Wt::WFormModel
 		}
 
 	private:
-
 		void initializeModels()
 		{
 			_updatePeriodModel = std::make_shared<ValueStringModel<ScanSettings::UpdatePeriod>>();

src/lms/ui/admin/InitWizardView.cpp

@@ -41,7 +41,6 @@ namespace UserInterface {
 class InitWizardModel : public Wt::WFormModel
 {
 	public:
-
 		// Associate each field with a unique string literal.
 		static inline const Field AdminLoginField {"admin-login"};
 		static inline const Field PasswordField {"password"};

src/lms/ui/admin/InitWizardView.hpp

@@ -27,7 +27,6 @@ class InitWizardView : public Wt::WTemplateFormView
 {
 	public:
 		InitWizardView();
-
 };
 
 } // namespace UserInterface

src/lms/ui/admin/ScannerController.cpp

@@ -55,7 +55,6 @@ durationToString(const Wt::WDateTime& begin, const Wt::WDateTime& end)
 class ReportResource : public Wt::WResource
 {
 	public:
-
 		ReportResource()
 		{
 			suggestFileName("report.txt");
@@ -268,7 +267,6 @@ ScannerController::refreshContents()
 			}
 			break;
 	}
-
 }
 
 } // namespace UserInterface

src/lms/ui/admin/UserView.cpp

@@ -47,7 +47,6 @@ using namespace Database;
 
 class UserModel : public Wt::WFormModel
 {
-
 	public:
 		static inline const Field LoginField {"login"};
 		static inline const Field PasswordField {"password"};

src/lms/ui/common/ValueStringModel.hpp

@@ -30,7 +30,6 @@ template <typename T>
 class ValueStringModel : public Wt::WStringListModel
 {
 	public:
-
 		T getValue(std::size_t row) const
 		{
 			return Wt::cpp17::any_cast<T>(data(index(static_cast<int>(row), 0), Wt::ItemDataRole::User));
@@ -78,7 +77,6 @@ class ValueStringModel : public Wt::WStringListModel
 		{
 			removeRows(0, rowCount());
 		}
-
 };
 
 } // namespace UserInterface

src/lms/ui/explore/Filters.cpp

@@ -124,7 +124,6 @@ Filters::showDialog()
 void
 Filters::add(ClusterId clusterId)
 {
-
 	if (std::find(std::cbegin(_clusterIds), std::cend(_clusterIds), clusterId) != std::cend(_clusterIds))
 		return;
 

src/lms/ui/explore/TrackListHelpers.cpp

@@ -106,7 +106,6 @@ namespace UserInterface::TrackListHelpers
 					starBtn->setText(Wt::WString::tr("Lms.Explore.unstar"));
 				}
 			});
-
 		}
 
 		entry->bindNew<Wt::WPushButton>("download", Wt::WString::tr("Lms.Explore.download"))

src/tools/metadata/LmsMetadata.cpp

@@ -194,7 +194,6 @@ int main(int argc, char *argv[])
 				parse(parser, file);
 			}
 		}
-
 	}
 	catch (std::exception& e)
 	{

src/tools/similarity-parameters/GeneticAlgorithm.hpp

@@ -50,7 +50,6 @@ class GeneticAlgorithm
 		Individual simulate(const std::vector<Individual>& initialPopulation);
 
 	private:
-
 		struct ScoredIndividual
 		{
 			Individual individual;

src/tools/similarity-parameters/LmsSimilarityParameters.cpp

@@ -324,7 +324,6 @@ static
 void
 printBadlyClassifiedTracks(Database::Session& session, FeaturesSearcher::TrainSettings trainSettings)
 {
-	
 	FeaturesSearcher searcher {session, trainSettings};
 
 	const std::vector<Database::IdType> trackIds = std::invoke([&]()
@@ -384,7 +383,6 @@ int main(int argc, char *argv[])
 {
 	try
 	{
-
 		// log to stdout
 //		ServiceProvider<Logger>::create<StreamLogger>(std::cout);