diff --git a/src/libs/recommendation/impl/clusters/ClustersClassifier.hpp b/src/libs/recommendation/impl/clusters/ClustersClassifier.hpp index 4619d5dc..53a7bd5f 100644 --- a/src/libs/recommendation/impl/clusters/ClustersClassifier.hpp +++ b/src/libs/recommendation/impl/clusters/ClustersClassifier.hpp @@ -36,7 +36,7 @@ namespace Recommendation private: - std::string_view getName() const { return "Clusters"; } + std::string_view getName() const override { return "Clusters"; } bool init(Database::Session&, bool) override {return true;} void requestCancelInit() override {} diff --git a/src/libs/recommendation/impl/features/FeaturesClassifier.hpp b/src/libs/recommendation/impl/features/FeaturesClassifier.hpp index ecf3b947..f20beec7 100644 --- a/src/libs/recommendation/impl/features/FeaturesClassifier.hpp +++ b/src/libs/recommendation/impl/features/FeaturesClassifier.hpp @@ -55,15 +55,15 @@ class FeaturesClassifier : public IClassifier static const FeatureSettingsMap& getDefaultTrainFeatureSettings(); private: - std::string_view getName() const { return "Features"; } + std::string_view getName() const override { return "Features"; } bool init(Database::Session& session, bool databaseChanged) override; void requestCancelInit() override; std::vector getSimilarTracksFromTrackList(Database::Session& session, Database::IdType tracklistId, std::size_t maxCount) const override; std::vector getSimilarTracks(Database::Session& session, const std::unordered_set& tracksId, std::size_t maxCount) const override; - std::vector getSimilarReleases(Database::Session& session, Database::IdType releaseId, std::size_t maxCount) const; - std::vector getSimilarArtists(Database::Session& session, Database::IdType artistId, std::size_t maxCount) const; + std::vector getSimilarReleases(Database::Session& session, Database::IdType releaseId, std::size_t maxCount) const override; + std::vector getSimilarArtists(Database::Session& session, Database::IdType artistId, std::size_t maxCount) const override; bool initFromCache(Database::Session& session, const FeaturesClassifierCache& cache); diff --git a/src/libs/subsonic/impl/ParameterParsing.cpp b/src/libs/subsonic/impl/ParameterParsing.cpp index dbfd0656..48dc09e4 100644 --- a/src/libs/subsonic/impl/ParameterParsing.cpp +++ b/src/libs/subsonic/impl/ParameterParsing.cpp @@ -23,14 +23,14 @@ namespace StringUtils { template<> std::optional - StringUtils::readAs(const std::string& str) + readAs(const std::string& str) { return API::Subsonic::IdFromString(str); } template<> std::optional - StringUtils::readAs(const std::string& str) + readAs(const std::string& str) { if (str == "true") return true; diff --git a/src/libs/subsonic/impl/ParameterParsing.hpp b/src/libs/subsonic/impl/ParameterParsing.hpp index 4b503238..c5cb15f3 100644 --- a/src/libs/subsonic/impl/ParameterParsing.hpp +++ b/src/libs/subsonic/impl/ParameterParsing.hpp @@ -90,10 +90,10 @@ namespace StringUtils { template<> std::optional - StringUtils::readAs(const std::string& str); + readAs(const std::string& str); template<> std::optional - StringUtils::readAs(const std::string& str); + readAs(const std::string& str); } diff --git a/src/libs/subsonic/impl/SubsonicResource.cpp b/src/libs/subsonic/impl/SubsonicResource.cpp index c09a4c98..ed7c87ce 100644 --- a/src/libs/subsonic/impl/SubsonicResource.cpp +++ b/src/libs/subsonic/impl/SubsonicResource.cpp @@ -65,7 +65,7 @@ namespace StringUtils { template<> std::optional - StringUtils::readAs(const std::string& str) + readAs(const std::string& str) { // Expects "X.Y.Z" const auto numbers {StringUtils::splitString(str, ".")}; diff --git a/src/tools/recommendation/LmsRecommendation.cpp b/src/tools/recommendation/LmsRecommendation.cpp index 954af8c0..31af307d 100644 --- a/src/tools/recommendation/LmsRecommendation.cpp +++ b/src/tools/recommendation/LmsRecommendation.cpp @@ -88,7 +88,7 @@ dumpRecommendation(Database::Session session, Recommendation::IEngine& engine) }; std::cout << "Processing release '" << releaseToString(releaseId) << "'" << std::endl; - for (Database::IdType similarReleaseId : engine.getSimilarReleases(session, {releaseId}, 3)) + for (Database::IdType similarReleaseId : engine.getSimilarReleases(session, releaseId, 3)) std::cout << "\t- Similar release '" << releaseToString(similarReleaseId) << "'" << std::endl; } @@ -110,7 +110,7 @@ dumpRecommendation(Database::Session session, Recommendation::IEngine& engine) }; std::cout << "Processing artist '" << artistToString(artistId) << "'" << std::endl; - for (Database::IdType similarArtistId : engine.getSimilarArtists(session, {artistId}, 3)) + for (Database::IdType similarArtistId : engine.getSimilarArtists(session, artistId, 3)) std::cout << "\t- Similar artist '" << artistToString(similarArtistId) << "'" << std::endl; }