Using visit to enumerate users

src/lms/ui/admin/UsersView.cpp

@@ -71,10 +71,10 @@ namespace lms::ui
 
         auto transaction{ LmsApp->getDbSession().createReadTransaction() };
 
-        const User::IdType currentUserId{ LmsApp->getUser() };
+        const UserId currentUserId{ LmsApp->getUserId() };
-        for (const UserId userId : User::find(LmsApp->getDbSession(), User::FindParameters{}).results)
+        User::find(LmsApp->getDbSession(), User::FindParameters{}, [&](const User::pointer& user)
             {
-            const User::pointer user{ User::find(LmsApp->getDbSession(), userId) };
+                const UserId userId{ user->getId() };
 
                 Wt::WTemplate* entry{ _container->addNew<Wt::WTemplate>(Wt::WString::tr("Lms.Admin.Users.template.entry")) };
 
@@ -89,12 +89,12 @@ namespace lms::ui
 
                 // Don't edit ourself this way
                 if (user->getId() == currentUserId)
-                continue;
+                    return;
 
                 entry->setCondition("if-edit", true);
                 Wt::WPushButton* editBtn = entry->bindNew<Wt::WPushButton>("edit-btn", Wt::WString::tr("Lms.template.edit-btn"), Wt::TextFormat::XHTML);
                 editBtn->setToolTip(Wt::WString::tr("Lms.edit"));
-            editBtn->clicked().connect([=]()
+                editBtn->clicked().connect([userId]()
                     {
                         LmsApp->setInternalPath("/admin/user/" + userId.toString(), true);
                     });
@@ -131,6 +131,6 @@ namespace lms::ui
 
                         LmsApp->getModalManager().show(std::move(modal));
                     });
-        }
+            });
     }
 } // namespace lms::ui