owen/supersonic
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix #729: add bounds checking to LyricsViewer

Browse Source
This commit is contained in:
Drew Weymouth
2025-10-03 16:38:43 -07:00
parent 9b75faf9bc
commit 153cb623b8
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/widgets/lyricsviewer.go
+4 -1
View File
@@ -95,7 +95,8 @@ func (l *LyricsViewer) UpdatePlayPos(timeSecs float64) {
} }
l.lastPlayPos = timeSecs l.lastPlayPos = timeSecs
// advance if needed // advance if needed
if l.lyrics.Lines[l.nextLyricLine].Start <= timeSecs { if l.nextLyricLine >= 0 && l.nextLyricLine < len(l.lyrics.Lines) &&
l.lyrics.Lines[l.nextLyricLine].Start <= timeSecs {
l.viewer.NextLine() l.viewer.NextLine()
if l.nextLyricLine < len(l.lyrics.Lines)-1 { if l.nextLyricLine < len(l.lyrics.Lines)-1 {
l.nextLyricLine++ l.nextLyricLine++
@@ -125,8 +126,10 @@ func (l *LyricsViewer) OnSeeked(timeSecs float64) {
} else { } else {
l.nextLyricLine = nextLine l.nextLyricLine = nextLine
} }
if nextLine >= 0 && nextLine <= len(l.lyrics.Lines) {
l.viewer.SetCurrentLine(nextLine /*one-indexed*/) l.viewer.SetCurrentLine(nextLine /*one-indexed*/)
} }
}
func (l *LyricsViewer) CreateRenderer() fyne.WidgetRenderer { func (l *LyricsViewer) CreateRenderer() fyne.WidgetRenderer {
return widget.NewSimpleRenderer(l.container) return widget.NewSimpleRenderer(l.container)