refactor: generic SliceContains

backend/app.go

@@ -125,7 +125,7 @@ func (a *App) setupMPV() error {
 	a.Player.SetAudioDevice(desiredDevice)
 
 	rgainOpts := []string{ReplayGainNone, ReplayGainAlbum, ReplayGainTrack}
-	if !sharedutil.StringSliceContains(rgainOpts, a.Config.ReplayGain.Mode) {
+	if !sharedutil.SliceContains(rgainOpts, a.Config.ReplayGain.Mode) {
 		a.Config.ReplayGain.Mode = ReplayGainNone
 	}
 	a.Player.SetReplayGainOptions(player.ReplayGainOptions{

sharedutil/sharedutil.go

@@ -7,18 +7,9 @@ import (
 	"github.com/dweymouth/go-subsonic/subsonic"
 )
 
-func StringSliceContains(slice []string, str string) bool {
+func SliceContains[T comparable](ts []T, t T) bool {
-	for _, s := range slice {
+	for _, x := range ts {
-		if s == str {
+		if x == t {
-			return true
-		}
-	}
-	return false
-}
-
-func IntSliceContains(slice []int, i int) bool {
-	for _, x := range slice {
-		if x == i {
 			return true
 		}
 	}
@@ -85,7 +76,7 @@ func ReorderTracks(tracks []*subsonic.Child, idxToMove []int, op TrackReorderOp)
 		topIdx := 0
 		botIdx := len(idxToMove)
 		for i, t := range tracks {
-			if IntSliceContains(idxToMove, i) {
+			if SliceContains(idxToMove, i) {
 				newTracks[topIdx] = t
 				topIdx++
 			} else {
@@ -97,7 +88,7 @@ func ReorderTracks(tracks []*subsonic.Child, idxToMove []int, op TrackReorderOp)
 		topIdx := 0
 		botIdx := len(tracks) - len(idxToMove)
 		for i, t := range tracks {
-			if IntSliceContains(idxToMove, i) {
+			if SliceContains(idxToMove, i) {
 				newTracks[botIdx] = t
 				botIdx++
 			} else {

ui/browsing/albumspage.go

@@ -67,7 +67,7 @@ func NewAlbumsPage(cfg *backend.AlbumsPageConfig, contr *controller.Controller,
 		SizeName: theme.SizeNameHeadingText,
 	}
 	a.sortOrder = NewSelect(backend.AlbumSortOrders, a.onSortOrderChanged)
-	if !sharedutil.StringSliceContains(backend.AlbumSortOrders, cfg.SortOrder) {
+	if !sharedutil.SliceContains(backend.AlbumSortOrders, cfg.SortOrder) {
 		cfg.SortOrder = string(backend.AlbumSortRecentlyAdded)
 	}
 	a.sortOrder.Selected = cfg.SortOrder