owen/supersonic
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix #391: ensure artist radio button updates properly when reusing artist page

Browse Source
This commit is contained in:
Drew Weymouth
2024-05-28 07:50:36 -07:00
parent 1d96b7097c
commit 653a2658d4
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/browsing/artistpage.go
+6 -1
View File
@@ -128,6 +128,7 @@ func (a *ArtistPage) Save() SavedPage {
tl.Clear() tl.Clear()
a.pool.Release(util.WidgetTypeTracklist, tl) a.pool.Release(util.WidgetTypeTracklist, tl)
} }
a.header.artistPage = nil
a.pool.Release(util.WidgetTypeArtistPageHeader, a.header) a.pool.Release(util.WidgetTypeArtistPageHeader, a.header)
if a.albumGrid != nil { if a.albumGrid != nil {
a.albumGrid.Clear() a.albumGrid.Clear()
@@ -320,7 +321,11 @@ func NewArtistPageHeader(page *ArtistPage) *ArtistPageHeader {
a.playBtn = widget.NewButtonWithIcon("Play Discography", theme.MediaPlayIcon(), func() { a.playBtn = widget.NewButtonWithIcon("Play Discography", theme.MediaPlayIcon(), func() {
go a.artistPage.contr.PlayArtistDiscography(a.artistID, false /*shuffle*/) go a.artistPage.contr.PlayArtistDiscography(a.artistID, false /*shuffle*/)
}) })
a.playRadioBtn = widget.NewButtonWithIcon("Play Artist Radio", myTheme.ShuffleIcon, a.artistPage.playArtistRadio) a.playRadioBtn = widget.NewButtonWithIcon("Play Artist Radio", myTheme.ShuffleIcon, func() {
// must not pass playArtistRadio func directly to NewButton
// because the artistPage bound to this header can change when reused
a.artistPage.playArtistRadio()
})
var pop *widget.PopUpMenu var pop *widget.PopUpMenu
a.menuBtn = widget.NewButtonWithIcon("", theme.MoreHorizontalIcon(), nil) a.menuBtn = widget.NewButtonWithIcon("", theme.MoreHorizontalIcon(), nil)