owen/supersonic
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix possible crash when switching servers with pending image fetches

Browse Source
This commit is contained in:
Drew Weymouth
2024-06-02 14:55:03 -07:00
parent 5e403580e6
commit 9766aedf7a
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/imagemanager.go
+10 -2
View File
@@ -249,7 +249,11 @@ func (i *ImageManager) fetchAndCacheCoverFromServer(ctx context.Context, coverID
case <-ctx.Done(): case <-ctx.Done():
return nil, context.Canceled return nil, context.Canceled
case i.serverFetchSema <- struct{}{}: // acquire case i.serverFetchSema <- struct{}{}: // acquire
img, err := i.s.Server.GetCoverArt(coverID, coverArtThumbnailSize) server := i.s.Server
if server == nil {
return nil, errors.New("logged out")
}
img, err := server.GetCoverArt(coverID, coverArtThumbnailSize)
<-i.serverFetchSema // release <-i.serverFetchSema // release
if err == nil { if err == nil {
if i.ensureCoverCacheDir() != "" { if i.ensureCoverCacheDir() != "" {
@@ -277,7 +281,11 @@ func (i *ImageManager) getFullSizeCoverArtFromServer(ctx context.Context, coverI
case <-ctx.Done(): case <-ctx.Done():
return nil, context.Canceled return nil, context.Canceled
case i.serverFetchSema <- struct{}{}: // acquire case i.serverFetchSema <- struct{}{}: // acquire
im, err := i.s.Server.GetCoverArt(coverID, 0) server := i.s.Server
if server == nil {
return nil, errors.New("logged out")
}
im, err := server.GetCoverArt(coverID, 0)
<-i.serverFetchSema // release <-i.serverFetchSema // release
if err == nil { if err == nil {
i.cachedFullSizeCover = im i.cachedFullSizeCover = im