Fix #798: Migrate SkipSSLVerify setting to per-server

backend/config.go

@@ -21,6 +21,7 @@ type ServerConnection struct {
 	AltHostname   string
 	Username      string
 	LegacyAuth    bool
+	SkipSSLVerify bool
 }
 
 type ServerConfig struct {
@@ -50,7 +51,7 @@ type AppConfig struct {
 	EnableLrcLib                bool
 	CustomLrcLibUrl             string
 	EnablePasswordStorage       bool
-	SkipSSLVerify               bool
+	SkipSSLVerify               bool // Deprecated: use per-server SkipSSLVerify. Drop in future version.
 	EnqueueBatchSize            int
 	Language                    string
 	DisableDPIDetection         bool
@@ -212,7 +213,6 @@ func DefaultConfig(appVersionTag string) *Config {
 			ShowTrackChangeNotification:        false,
 			EnableLrcLib:                       true,
 			EnablePasswordStorage:              true,
-			SkipSSLVerify:                      false,
 			EnqueueBatchSize:                   100,
 			Language:                           "auto",
 			EnableAutoUpdateChecker:            true,
@@ -311,6 +311,7 @@ func ReadConfigFile(filepath, appVersionTag string) (*Config, error) {
 	if err := toml.NewDecoder(f).Decode(c); err != nil {
 		return nil, err
 	}
+	c.migrateDeprecatedSettings()
 
 	// Backfill Subsonic to empty ServerType fields
 	// for updating configs created before multiple MediaProviders were added
@@ -331,6 +332,8 @@ func (c *Config) WriteConfigFile(filepath string) error {
 	}
 	defer writeLock.Unlock()
 
+	// clear deprecated global SkipSSLVerify after migrating to per-server settings
+	c.Application.SkipSSLVerify = false
 	b, err := toml.Marshal(c)
 	if err != nil {
 		return err
@@ -339,3 +342,12 @@ func (c *Config) WriteConfigFile(filepath string) error {
 
 	return nil
 }
+
+func (c *Config) migrateDeprecatedSettings() {
+	// Migrate deprecated global SkipSSLVerify to per-server settings
+	if c.Application.SkipSSLVerify {
+		for _, s := range c.Servers {
+			s.SkipSSLVerify = true
+		}
+	}
+}

backend/servermanager.go

@@ -185,7 +185,7 @@ func (s *ServerManager) connect(connection ServerConnection, password string) (m
 			log.Printf("error creating Jellyfin client: %s", err.Error())
 			return nil, err
 		}
-		s.checkSetInsecureSkipVerify(client.HTTPClient)
+		s.checkSetInsecureSkipVerify(connection.SkipSSLVerify, client.HTTPClient)
 		cli = &jellyfinMP.JellyfinServer{
 			Client: *client,
 		}
@@ -196,7 +196,7 @@ func (s *ServerManager) connect(connection ServerConnection, password string) (m
 				log.Printf("error creating Jellyfin alternative client: %s", err.Error())
 				return nil, err
 			}
-			s.checkSetInsecureSkipVerify(altClient.HTTPClient)
+			s.checkSetInsecureSkipVerify(connection.SkipSSLVerify, altClient.HTTPClient)
 			altCli = &jellyfinMP.JellyfinServer{
 				Client: *altClient,
 			}
@@ -213,7 +213,7 @@ func (s *ServerManager) connect(connection ServerConnection, password string) (m
 				ClientName:   res.AppName,
 			},
 		}
-		s.checkSetInsecureSkipVerify(cli.(*subsonicMP.SubsonicServer).Client.Client)
+		s.checkSetInsecureSkipVerify(connection.SkipSSLVerify, cli.(*subsonicMP.SubsonicServer).Client.Client)
 		altCli = &subsonicMP.SubsonicServer{
 			Client: subsonic.Client{
 				UserAgent:    ua,
@@ -224,7 +224,7 @@ func (s *ServerManager) connect(connection ServerConnection, password string) (m
 				ClientName:   res.AppName,
 			},
 		}
-		s.checkSetInsecureSkipVerify(altCli.(*subsonicMP.SubsonicServer).Client.Client)
+		s.checkSetInsecureSkipVerify(connection.SkipSSLVerify, altCli.(*subsonicMP.SubsonicServer).Client.Client)
 	}
 	var authError error
 	pingChan := make(chan bool, 2) // false for primary hostname, true for alternate
@@ -255,8 +255,8 @@ func (s *ServerManager) connect(connection ServerConnection, password string) (m
 	}
 }
 
-func (s *ServerManager) checkSetInsecureSkipVerify(cli *http.Client) {
+func (s *ServerManager) checkSetInsecureSkipVerify(skip bool, cli *http.Client) {
-	if s.config.Application.SkipSSLVerify {
+	if skip {
 		cli.Transport = &http.Transport{
 			TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
 		}

ui/controller/serverconnection.go

@@ -32,6 +32,7 @@ func (m *Controller) PromptForFirstServer() {
 					AltHostname:   d.AltHost,
 					Username:      d.Username,
 					LegacyAuth:    d.LegacyAuth,
+					SkipSSLVerify: d.SkipSSLVerify,
 				}
 				server := m.App.ServerManager.AddServer(d.Nickname, conn)
 				if err := m.trySetPasswordAndConnectToServer(server, d.Password); err != nil {
@@ -138,6 +139,7 @@ func (m *Controller) PromptForLoginAndConnect() {
 						server.Nickname = editD.Nickname
 						server.Username = editD.Username
 						server.LegacyAuth = editD.LegacyAuth
+						server.SkipSSLVerify = editD.SkipSSLVerify
 						m.trySetPasswordAndConnectToServer(server, editD.Password)
 						m.doModalClosed()
 					}
@@ -169,6 +171,7 @@ func (m *Controller) PromptForLoginAndConnect() {
 							AltHostname:   newD.AltHost,
 							Username:      newD.Username,
 							LegacyAuth:    newD.LegacyAuth,
+							SkipSSLVerify: newD.SkipSSLVerify,
 						}
 						server := m.App.ServerManager.AddServer(newD.Nickname, conn)
 						m.trySetPasswordAndConnectToServer(server, newD.Password)
@@ -238,6 +241,7 @@ func (c *Controller) testConnectionAndUpdateDialogText(dlg *dialogs.AddEditServe
 		AltHostname:   dlg.AltHost,
 		Username:      dlg.Username,
 		LegacyAuth:    dlg.LegacyAuth,
+		SkipSSLVerify: dlg.SkipSSLVerify,
 	}
 	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
 	defer cancel()

ui/dialogs/addeditserverdialog.go

@@ -24,6 +24,7 @@ type AddEditServerDialog struct {
 	Username      string
 	Password      string
 	LegacyAuth    bool
+	SkipSSLVerify bool
 	OnSubmit      func()
 	OnCancel      func()
 
@@ -45,6 +46,7 @@ func NewAddEditServerDialog(title string, cancelable bool, prefillServer *backen
 		a.AltHost = prefillServer.AltHostname
 		a.Username = prefillServer.Username
 		a.LegacyAuth = prefillServer.LegacyAuth
+		a.SkipSSLVerify = prefillServer.SkipSSLVerify
 	}
 
 	titleLabel := widget.NewLabel(title)
@@ -58,6 +60,7 @@ func NewAddEditServerDialog(title string, cancelable bool, prefillServer *backen
 			legacyAuthCheck.Hide()
 		}
 	})
+	skipSSLCheck := widget.NewCheckWithData(lang.L("Skip SSL certificate verification"), binding.BindBool(&a.SkipSSLVerify))
 	serverTypeChoice.Required = true
 	serverTypeChoice.Horizontal = true
 	selected := backend.ServerTypeSubsonic
@@ -113,7 +116,7 @@ func NewAddEditServerDialog(title string, cancelable bool, prefillServer *backen
 			widget.NewLabel(lang.L("Password")),
 			a.passField,
 		),
-		container.NewHBox(layout.NewSpacer(), legacyAuthCheck),
+		container.NewHBox(layout.NewSpacer(), legacyAuthCheck, skipSSLCheck),
 		widget.NewSeparator(),
 		bottomRow,
 	)

ui/dialogs/settingsdialog.go

@@ -617,7 +617,6 @@ func (s *SettingsDialog) createAppearanceTab(window fyne.Window) *container.TabI
 
 func (s *SettingsDialog) createAdvancedTab() *container.TabItem {
 	multi := widget.NewCheckWithData(lang.L("Allow multiple app instances"), binding.BindBool(&s.config.Application.AllowMultiInstance))
-	sslSkip := widget.NewCheckWithData(lang.L("Skip SSL certificate verification"), binding.BindBool(&s.config.Application.SkipSSLVerify))
 	update := widget.NewCheckWithData(lang.L("Automatically check for updates"), binding.BindBool(&s.config.Application.EnableAutoUpdateChecker))
 	lrclib := widget.NewCheckWithData(lang.L("Enable LrcLib lyrics fetcher"), binding.BindBool(&s.config.Application.EnableLrcLib))
 
@@ -659,7 +658,6 @@ func (s *SettingsDialog) createAdvancedTab() *container.TabItem {
 
 	return container.NewTabItem(lang.L("Advanced"), container.NewVBox(
 		multi,
-		sslSkip,
 		update,
 		lrclib,
 		osMediaAPIs,