rework settings dialog to be aware of different player types

ui/controller/controller.go

@@ -472,31 +472,39 @@ func (c *Controller) ShowAboutDialog() {
 }
 
 func (c *Controller) ShowSettingsDialog(themeUpdateCallbk func(), themeFiles map[string]string) {
-	devs, err := c.App.Player.ListAudioDevices()
+	devs, err := c.App.LocalPlayer.ListAudioDevices()
 	if err != nil {
 		log.Printf("error listing audio devices: %v", err)
 		devs = []mpv.AudioDevice{{Name: "auto", Description: "Autoselect device"}}
 	}
 
-	bands := c.App.Player.Equalizer().BandFrequencies()
-	dlg := dialogs.NewSettingsDialog(c.App.Config, devs, themeFiles, bands, c.App.ServerManager.Server.ClientDecidesScrobble(), c.MainWindow)
+	curPlayer := c.App.PlaybackManager.CurrentPlayer()
+	_, isReplayGainPlayer := curPlayer.(player.ReplayGainPlayer)
+	_, isEqualizerPlayer := curPlayer.(*mpv.Player)
+	isLocalPlayer := isEqualizerPlayer
+	bands := c.App.LocalPlayer.Equalizer().BandFrequencies()
+	dlg := dialogs.NewSettingsDialog(c.App.Config,
+		devs, themeFiles, bands,
+		c.App.ServerManager.Server.ClientDecidesScrobble(),
+		isLocalPlayer, isReplayGainPlayer, isEqualizerPlayer,
+		c.MainWindow)
 	dlg.OnReplayGainSettingsChanged = func() {
 		c.App.PlaybackManager.SetReplayGainOptions(c.App.Config.ReplayGain)
 	}
 	dlg.OnAudioExclusiveSettingChanged = func() {
-		c.App.Player.SetAudioExclusive(c.App.Config.LocalPlayback.AudioExclusive)
+		c.App.LocalPlayer.SetAudioExclusive(c.App.Config.LocalPlayback.AudioExclusive)
 	}
 	dlg.OnAudioDeviceSettingChanged = func() {
-		c.App.Player.SetAudioDevice(c.App.Config.LocalPlayback.AudioDeviceName)
+		c.App.LocalPlayer.SetAudioDevice(c.App.Config.LocalPlayback.AudioDeviceName)
 	}
 	dlg.OnThemeSettingChanged = themeUpdateCallbk
 	dlg.OnEqualizerSettingsChanged = func() {
 		// currently we only have one equalizer type
-		eq := c.App.Player.Equalizer().(*mpv.ISO15BandEqualizer)
+		eq := c.App.LocalPlayer.Equalizer().(*mpv.ISO15BandEqualizer)
 		eq.Disabled = !c.App.Config.LocalPlayback.EqualizerEnabled
 		eq.EQPreamp = c.App.Config.LocalPlayback.EqualizerPreamp
 		copy(eq.BandGains[:], c.App.Config.LocalPlayback.GraphicEqualizerBands)
-		c.App.Player.SetEqualizer(eq)
+		c.App.LocalPlayer.SetEqualizer(eq)
 	}
 	pop := widget.NewModalPopUp(dlg, c.MainWindow.Canvas())
 	dlg.OnDismiss = func() {

ui/dialogs/settingsdialog.go

@@ -46,24 +46,39 @@ type SettingsDialog struct {
 	content fyne.CanvasObject
 }
 
-// TODO: having this depend on the player package for the AudioDevice type is kinda gross. Refactor.
+// TODO: having this depend on the mpv package for the AudioDevice type is kinda gross. Refactor.
 func NewSettingsDialog(
 	config *backend.Config,
 	audioDeviceList []mpv.AudioDevice,
 	themeFileList map[string]string,
 	equalizerBands []string,
 	clientDecidesScrobble bool,
+	isLocalPlayer bool,
+	isReplayGainPlayer bool,
+	isEqualizerPlayer bool,
 	window fyne.Window,
 ) *SettingsDialog {
 	s := &SettingsDialog{config: config, audioDevices: audioDeviceList, themeFiles: themeFileList, clientDecidesScrobble: clientDecidesScrobble}
 	s.ExtendBaseWidget(s)
 
-	tabs := container.NewAppTabs(
-		s.createGeneralTab(),
-		s.createPlaybackTab(),
-		s.createEqualizerTab(equalizerBands),
-		s.createExperimentalTab(window),
-	)
+	// TODO: Once Fyne supports disableable sliders, it's probably a nicer UX
+	// to create the equalizer tab but disable it if we are not using an equalizer player
+	var tabs *container.AppTabs
+	if isEqualizerPlayer {
+		tabs = container.NewAppTabs(
+			s.createGeneralTab(),
+			s.createPlaybackTab(isLocalPlayer, isReplayGainPlayer),
+			s.createEqualizerTab(equalizerBands),
+			s.createExperimentalTab(window),
+		)
+	} else {
+		tabs = container.NewAppTabs(
+			s.createGeneralTab(),
+			s.createPlaybackTab(isLocalPlayer, isReplayGainPlayer),
+			s.createExperimentalTab(window),
+		)
+	}
+
 	tabs.SelectIndex(s.getActiveTabNumFromConfig())
 	// workaround issue where inactivated tabs don't fully update when theme setting is changed
 	tabs.OnSelected = func(ti *container.TabItem) {
@@ -249,7 +264,7 @@ func (s *SettingsDialog) createGeneralTab() *container.TabItem {
 	))
 }
 
-func (s *SettingsDialog) createPlaybackTab() *container.TabItem {
+func (s *SettingsDialog) createPlaybackTab(isLocalPlayer, isReplayGainPlayer bool) *container.TabItem {
 	disableTranscode := widget.NewCheckWithData("Disable server transcoding", binding.BindBool(&s.config.Transcoding.ForceRawFile))
 	deviceList := make([]string, len(s.audioDevices))
 	var selIndex int
@@ -328,6 +343,16 @@ func (s *SettingsDialog) createPlaybackTab() *container.TabItem {
 	})
 	audioExclusive.Checked = s.config.LocalPlayback.AudioExclusive
 
+	if !isLocalPlayer {
+		deviceSelect.Disable()
+		audioExclusive.Disable()
+	}
+	if !isReplayGainPlayer {
+		replayGainSelect.Disable()
+		preventClipping.Disable()
+		preampGain.Disable()
+	}
+
 	return container.NewTabItem("Playback", container.NewVBox(
 		container.NewHBox(disableTranscode),
 		container.New(&layouts.MaxPadLayout{PadTop: 5},