owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Transcoding: force setting the channel count to workaround when the input channel layout is not compatible with the codec selected, fixes #781

Browse Source
This commit is contained in:
emeric
2025-12-08 21:51:21 +01:00
parent d3f260bfe6
commit 1dce97bddd
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/audio/impl/ffmpeg/Transcoder.cpp
+4 -3
View File
@@ -87,7 +87,7 @@ namespace lms::audio::ffmpeg
} }
catch (const std::filesystem::filesystem_error& e) catch (const std::filesystem::filesystem_error& e)
{ {
throw IOFileException{ _inputParams.filePath, "Failed to test file existence", e.code() }; throw IOFileException{ _inputParams.filePath, "Failed to check if file exists", e.code() };
} }
LOG(INFO, "Transcoding file " << _inputParams.filePath); LOG(INFO, "Transcoding file " << _inputParams.filePath);
@@ -136,10 +136,11 @@ namespace lms::audio::ffmpeg
args.emplace_back(std::to_string(*_outputParams.bitrate)); args.emplace_back(std::to_string(*_outputParams.bitrate));
} }
if (_outputParams.channelCount) // -ac doc says: "For output streams it is set by default to the number of input audio channels".
// But it looks like specifying it is required in case the original layout is not compatible with the output codec selected
{ {
args.emplace_back("-ac"); args.emplace_back("-ac");
args.emplace_back(std::to_string(*_outputParams.channelCount)); args.emplace_back(std::to_string(_outputParams.channelCount ? *_outputParams.channelCount : _inputParams.audioProperties.channelCount));
} }
if (_outputParams.sampleRate) if (_outputParams.sampleRate)