Various minor cleanup

src/libs/services/scrobbling/impl/IScrobblingBackend.hpp

@@ -20,7 +20,6 @@
 #pragma once
 
 #include <chrono>
-#include <memory>
 #include <optional>
 
 #include "services/scrobbling/Listen.hpp"

src/libs/services/scrobbling/include/services/scrobbling/IScrobblingService.hpp

@@ -134,5 +134,5 @@ namespace lms::scrobbling
         virtual TrackContainer getTopTracks(const FindParameters& params) = 0;
     };
 
-    std::unique_ptr<IScrobblingService> createScrobblingService(boost::asio::io_service& ioService, db::Db& db);
+    std::unique_ptr<IScrobblingService> createScrobblingService(boost::asio::io_context& ioContext, db::Db& db);
 } // namespace lms::scrobbling

src/libs/subsonic/impl/SubsonicResource.cpp

@@ -65,7 +65,7 @@ namespace lms::api::subsonic
 
             core::Service<core::IConfig>::get()->visitStrings("api-subsonic-old-server-protocol-clients",
                 [&](std::string_view client) {
-                    res.emplace(std::string{ client }, ProtocolVersion{ 1, 12, 0 });
+                    res.emplace(std::string{ client }, ProtocolVersion{ .major = 1, .minor = 12, .patch = 0 });
                 },
                 { "DSub" });
 

src/libs/subsonic/impl/endpoints/Browsing.cpp

@@ -164,7 +164,7 @@ namespace lms::api::subsonic
             return tracks;
         }
 
-        std::vector<TrackId> findSimilarSongs(RequestContext&, TrackId trackId, std::size_t count)
+        std::vector<TrackId> findSimilarSongs(RequestContext& /*context*/, TrackId trackId, std::size_t count)
         {
             return core::Service<recommendation::IRecommendationService>::get()->findSimilarTracks({ trackId }, count);
         }