Do not apply global filters on artist an release views

This commit is contained in:
emeric
2025-12-08 21:00:44 +01:00
parent 40b4096ab0
commit d51ff0a03f
5 changed files with 3 additions and 19 deletions
+1 -8
View File
@@ -80,11 +80,6 @@ namespace lms::ui
refreshView();
});
filters.updated().connect([this] {
_needForceRefresh = true;
refreshView();
});
refreshView();
}
@@ -96,13 +91,12 @@ namespace lms::ui
const auto artistId{ extractArtistIdFromInternalPath() };
// consider everything is up to date is the same artist is being rendered
if (!_needForceRefresh && artistId && *artistId == _artistId)
if (artistId && *artistId == _artistId)
return;
clear();
_artistId = {};
_trackContainer = nullptr;
_needForceRefresh = false;
if (!artistId)
throw ArtistNotFoundException{};
@@ -236,7 +230,6 @@ namespace lms::ui
_releaseContainers.clear();
db::Release::FindParameters params;
params.setFilters(_filters.getDbFilters());
params.setArtist(_artistId, { db::TrackArtistLinkType::ReleaseArtist }, {});
params.setSortMethod(LmsApp->getUser()->getUIArtistReleaseSortMethod());
-1
View File
@@ -76,6 +76,5 @@ namespace lms::ui
ReleaseContainer _appearsOnReleaseContainer{};
InfiniteScrollingContainer* _trackContainer{};
db::ArtistId _artistId{};
bool _needForceRefresh{};
};
} // namespace lms::ui
+1 -8
View File
@@ -255,11 +255,6 @@ namespace lms::ui
refreshView();
});
_filters.updated().connect([this] {
_needForceRefresh = true;
refreshView();
});
refreshView();
}
@@ -271,12 +266,11 @@ namespace lms::ui
const auto releaseId{ extractReleaseIdFromInternalPath() };
// consider everything is up to date is the same release is being rendered
if (!_needForceRefresh && releaseId && *releaseId == _releaseId)
if (releaseId && *releaseId == _releaseId)
return;
clear();
_releaseId = {};
_needForceRefresh = false;
if (!releaseId)
throw ReleaseNotFoundException{};
@@ -451,7 +445,6 @@ namespace lms::ui
db::Track::FindParameters params;
params.setMedium(medium->getId());
params.setSortMethod(db::TrackSortMethod::TrackNumber);
params.setFilters(_filters.getDbFilters()); // TODO: do we really want to hide all tracks when a release does not match the current label filter?
db::Track::find(LmsApp->getDbSession(), params, [&](const db::Track::pointer& track) {
const db::TrackId trackId{ track->getId() };
-1
View File
@@ -57,6 +57,5 @@ namespace lms::ui
Filters& _filters;
PlayQueueController& _playQueueController;
db::ReleaseId _releaseId;
bool _needForceRefresh{};
};
} // namespace lms::ui