Fixed some warnings. ref #322

src/libs/services/database/include/services/database/Artist.hpp

@@ -49,7 +49,7 @@ class Track;
 class TrackArtistLink;
 class User;
 
-class Artist : public Object<Artist, ArtistId>
+class Artist final : public Object<Artist, ArtistId>
 {
 	public:
 		struct FindParameters

src/libs/services/database/include/services/database/AuthToken.hpp

@@ -32,7 +32,7 @@ namespace Database
 	class Session;
 
 	class User;
-	class AuthToken : public Object<AuthToken, AuthTokenId>
+	class AuthToken final : public Object<AuthToken, AuthTokenId>
 	{
 		public:
 			AuthToken() = default;

src/libs/services/database/include/services/database/Cluster.hpp

@@ -38,7 +38,7 @@ class ClusterType;
 class ScanSettings;
 class Session;
 
-class Cluster : public Object<Cluster, ClusterId>
+class Cluster final : public Object<Cluster, ClusterId>
 {
 	public:
 		Cluster() = default;
@@ -81,7 +81,7 @@ class Cluster : public Object<Cluster, ClusterId>
 };
 
 
-class ClusterType : public Object<ClusterType, ClusterTypeId>
+class ClusterType final : public Object<ClusterType, ClusterTypeId>
 {
 	public:
 		ClusterType() = default;

src/libs/services/database/include/services/database/Listen.hpp

@@ -38,7 +38,7 @@ class Session;
 class Track;
 class User;
 
-class Listen : public Object<Listen, ListenId>
+class Listen final : public Object<Listen, ListenId>
 {
 	public:
 		Listen() = default;

src/libs/services/database/include/services/database/Release.hpp

@@ -45,7 +45,7 @@ class Session;
 class Track;
 class User;
 
-class Release : public Object<Release, ReleaseId>
+class Release final : public Object<Release, ReleaseId>
 {
 	public:
 		struct FindParameters

src/libs/services/database/include/services/database/ScanSettings.hpp

@@ -35,7 +35,7 @@ namespace Database {
 class ClusterType;
 class Session;
 
-class ScanSettings : public Object<ScanSettings, ScanSettingsId>
+class ScanSettings final : public Object<ScanSettings, ScanSettingsId>
 {
 	public:
 		// Do not modify values (just add)

src/libs/services/database/include/services/database/StarredArtist.hpp

@@ -34,7 +34,7 @@ namespace Database
 	class Session;
 	class User;
 
-	class StarredArtist : public Object<StarredArtist, StarredArtistId>
+	class StarredArtist final : public Object<StarredArtist, StarredArtistId>
 	{
 		public:
 			StarredArtist() = default;

src/libs/services/database/include/services/database/StarredRelease.hpp

@@ -34,7 +34,7 @@ namespace Database
 	class Session;
 	class User;
 
-	class StarredRelease : public Object<StarredRelease, StarredReleaseId>
+	class StarredRelease final : public Object<StarredRelease, StarredReleaseId>
 	{
 		public:
 			StarredRelease() = default;

src/libs/services/database/include/services/database/StarredTrack.hpp

@@ -35,7 +35,7 @@ namespace Database
 	class Session;
 	class User;
 
-	class StarredTrack : public Object<StarredTrack, StarredTrackId>
+	class StarredTrack final : public Object<StarredTrack, StarredTrackId>
 	{
 		public:
 			StarredTrack() = default;

src/libs/services/database/include/services/database/Track.hpp

@@ -56,7 +56,7 @@ class TrackArtistLink;
 class TrackStats;
 class User;
 
-class Track : public Object<Track, TrackId>
+class Track final : public Object<Track, TrackId>
 {
 	public:
 		struct FindParameters

src/libs/services/database/include/services/database/TrackArtistLink.hpp

@@ -35,12 +35,11 @@ LMS_DECLARE_IDTYPE(TrackArtistLinkId)
 
 namespace Database
 {
-
 	class Artist;
 	class Session;
 	class Track;
 
-	class TrackArtistLink : public Object<TrackArtistLink, TrackArtistLinkId>
+	class TrackArtistLink final : public Object<TrackArtistLink, TrackArtistLinkId>
 	{
 		public:
 			struct FindParameters

src/libs/services/database/include/services/database/TrackBookmark.hpp

@@ -37,7 +37,7 @@ class Session;
 class Track;
 class User;
 
-class TrackBookmark : public Object<TrackBookmark, TrackBookmarkId>
+class TrackBookmark final : public Object<TrackBookmark, TrackBookmarkId>
 {
 	public:
 		TrackBookmark () = default;

src/libs/services/database/include/services/database/TrackFeatures.hpp

@@ -42,7 +42,7 @@ using FeatureName = std::string;
 using FeatureValues  = std::vector<double>;
 using FeatureValuesMap = std::unordered_map<FeatureName, FeatureValues>;
 
-class TrackFeatures : public Object<TrackFeatures, TrackFeaturesId>
+class TrackFeatures final : public Object<TrackFeatures, TrackFeaturesId>
 {
 	public:
 		TrackFeatures() = default;

src/libs/services/database/include/services/database/TrackList.hpp

@@ -45,7 +45,7 @@ class Track;
 class TrackListEntry;
 class User;
 
-class TrackList : public Object<TrackList, TrackListId>
+class TrackList final : public Object<TrackList, TrackListId>
 {
 	public:
 		TrackList() = default;

src/libs/services/database/include/services/database/User.hpp

@@ -36,7 +36,7 @@ namespace Database {
 class AuthToken;
 class Session;
 
-class User : public Object<User, UserId>
+class User final : public Object<User, UserId>
 {
 	public:
 		struct PasswordHash

src/libs/services/recommendation/include/services/recommendation/IPlaylistGeneratorService.hpp

@@ -35,6 +35,8 @@ namespace Recommendation
 	class IPlaylistGeneratorService
 	{
 		public:
+			virtual ~IPlaylistGeneratorService() = default;
+
 			// extend an existing playlist with similar tracks (but use playlist contraints)
 			virtual TrackContainer extendPlaylist(Database::TrackListId tracklistId, std::size_t maxCount) const = 0;
 	};

src/lms/ui/ModalManager.cpp

@@ -60,7 +60,7 @@ namespace UserInterface
 
 		doJavaScript(oss.str());
 
-		addWidget(move(modalWidget));
+		addWidget(std::move(modalWidget));
 	}
 
 	void

src/lms/ui/admin/DatabaseSettingsView.cpp

@@ -44,7 +44,6 @@ namespace UserInterface {
 
 using namespace Database;
 
-
 class DatabaseSettingsModel : public Wt::WFormModel
 {
 	public:
@@ -69,7 +68,7 @@ class DatabaseSettingsModel : public Wt::WFormModel
 
 			auto dirValidator {createDirectoryValidator()};
 			dirValidator->setMandatory(true);
-			setValidator(MediaDirectoryField, move(dirValidator));
+			setValidator(MediaDirectoryField, std::move(dirValidator));
 
 			setValidator(UpdatePeriodField, createMandatoryValidator());
 			setValidator(UpdateStartTimeField, createMandatoryValidator());

src/lms/ui/explore/ArtistView.cpp

@@ -272,7 +272,7 @@ Artist::refreshAppearsOnReleases()
 		releaseContainer->bindString("release-type", Wt::WString::tr("Lms.Explore.Artist.appears-on"));
 		_appearsOnReleaseContainer.releases = releases.results;
 		_appearsOnReleaseContainer.container = releaseContainer->bindNew<InfiniteScrollingContainer>("releases", Wt::WString::tr("Lms.Explore.Releases.template.container"));
-		_appearsOnReleaseContainer.container->onRequestElements.connect(this, [this, &releases]
+		_appearsOnReleaseContainer.container->onRequestElements.connect(this, [this]
 		{
 			addSomeReleases(_appearsOnReleaseContainer);
 		});