owen/lms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix some compilation warnings

Browse Source
This commit is contained in:
emeric
2020-03-29 14:16:58 +02:00
parent f4d1202dda
commit f5034e1e7b
6 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libs/recommendation/impl/clusters/ClustersClassifier.hpp
+1 -1
View File
@@ -36,7 +36,7 @@ namespace Recommendation
private:
std::string_view getName() const { return "Clusters"; }
std::string_view getName() const override { return "Clusters"; }
bool init(Database::Session&, bool) override {return true;}
void requestCancelInit() override {}
src/libs/recommendation/impl/features/FeaturesClassifier.hpp
+3 -3
View File
@@ -55,15 +55,15 @@ class FeaturesClassifier : public IClassifier
static const FeatureSettingsMap& getDefaultTrainFeatureSettings();
private:
std::string_view getName() const { return "Features"; }
std::string_view getName() const override { return "Features"; }
bool init(Database::Session& session, bool databaseChanged) override;
void requestCancelInit() override;
std::vector<Database::IdType> getSimilarTracksFromTrackList(Database::Session& session, Database::IdType tracklistId, std::size_t maxCount) const override;
std::vector<Database::IdType> getSimilarTracks(Database::Session& session, const std::unordered_set<Database::IdType>& tracksId, std::size_t maxCount) const override;
std::vector<Database::IdType> getSimilarReleases(Database::Session& session, Database::IdType releaseId, std::size_t maxCount) const;
std::vector<Database::IdType> getSimilarArtists(Database::Session& session, Database::IdType artistId, std::size_t maxCount) const;
std::vector<Database::IdType> getSimilarReleases(Database::Session& session, Database::IdType releaseId, std::size_t maxCount) const override;
std::vector<Database::IdType> getSimilarArtists(Database::Session& session, Database::IdType artistId, std::size_t maxCount) const override;
bool initFromCache(Database::Session& session, const FeaturesClassifierCache& cache);
src/libs/subsonic/impl/ParameterParsing.cpp
+2 -2
View File
@@ -23,14 +23,14 @@ namespace StringUtils
{
template<>
std::optional<API::Subsonic::Id>
StringUtils::readAs(const std::string& str)
readAs(const std::string& str)
{
return API::Subsonic::IdFromString(str);
}
template<>
std::optional<bool>
StringUtils::readAs(const std::string& str)
readAs(const std::string& str)
{
if (str == "true")
return true;
src/libs/subsonic/impl/ParameterParsing.hpp
+2 -2
View File
@@ -90,10 +90,10 @@ namespace StringUtils
{
template<>
std::optional<API::Subsonic::Id>
StringUtils::readAs(const std::string& str);
readAs(const std::string& str);
template<>
std::optional<bool>
StringUtils::readAs(const std::string& str);
readAs(const std::string& str);
}
src/libs/subsonic/impl/SubsonicResource.cpp
+1 -1
View File
@@ -65,7 +65,7 @@ namespace StringUtils
{
template<>
std::optional<API::Subsonic::ClientVersion>
StringUtils::readAs(const std::string& str)
readAs(const std::string& str)
{
// Expects "X.Y.Z"
const auto numbers {StringUtils::splitString(str, ".")};