Fix some compilation warnings

src/libs/recommendation/impl/clusters/ClustersClassifier.hpp

@@ -36,7 +36,7 @@ namespace Recommendation
 
 		private:
 
-			std::string_view getName() const { return "Clusters"; }
+			std::string_view getName() const override { return "Clusters"; }
 
 			bool init(Database::Session&, bool) override {return true;}
 			void requestCancelInit() override {}

src/libs/recommendation/impl/features/FeaturesClassifier.hpp

@@ -55,15 +55,15 @@ class FeaturesClassifier : public IClassifier
 		static const FeatureSettingsMap& getDefaultTrainFeatureSettings();
 	private:
 
-		std::string_view getName() const { return "Features"; }
+		std::string_view getName() const override { return "Features"; }
 
 		bool init(Database::Session& session, bool databaseChanged) override;
 		void requestCancelInit() override;
 
 		std::vector<Database::IdType> getSimilarTracksFromTrackList(Database::Session& session, Database::IdType tracklistId, std::size_t maxCount) const override;
 		std::vector<Database::IdType> getSimilarTracks(Database::Session& session, const std::unordered_set<Database::IdType>& tracksId, std::size_t maxCount) const override;
-		std::vector<Database::IdType> getSimilarReleases(Database::Session& session, Database::IdType releaseId, std::size_t maxCount) const;
+		std::vector<Database::IdType> getSimilarReleases(Database::Session& session, Database::IdType releaseId, std::size_t maxCount) const override;
-		std::vector<Database::IdType> getSimilarArtists(Database::Session& session, Database::IdType artistId, std::size_t maxCount) const;
+		std::vector<Database::IdType> getSimilarArtists(Database::Session& session, Database::IdType artistId, std::size_t maxCount) const override;
 
 		bool initFromCache(Database::Session& session, const FeaturesClassifierCache& cache);
 

src/libs/subsonic/impl/ParameterParsing.cpp

@@ -23,14 +23,14 @@ namespace StringUtils
 {
 	template<>
 	std::optional<API::Subsonic::Id>
-	StringUtils::readAs(const std::string& str)
+	readAs(const std::string& str)
 	{
 		return API::Subsonic::IdFromString(str);
 	}
 
 	template<>
 	std::optional<bool>
-	StringUtils::readAs(const std::string& str)
+	readAs(const std::string& str)
 	{
 		if (str == "true")
 			return true;

src/libs/subsonic/impl/ParameterParsing.hpp

@@ -90,10 +90,10 @@ namespace StringUtils
 {
 	template<>
 	std::optional<API::Subsonic::Id>
-	StringUtils::readAs(const std::string& str);
+	readAs(const std::string& str);
 
 	template<>
 	std::optional<bool>
-	StringUtils::readAs(const std::string& str);
+	readAs(const std::string& str);
 }
 

src/libs/subsonic/impl/SubsonicResource.cpp

@@ -65,7 +65,7 @@ namespace StringUtils
 {
 	template<>
 	std::optional<API::Subsonic::ClientVersion>
-	StringUtils::readAs(const std::string& str)
+	readAs(const std::string& str)
 	{
 		// Expects "X.Y.Z"
 		const auto numbers {StringUtils::splitString(str, ".")};

src/tools/recommendation/LmsRecommendation.cpp

@@ -88,7 +88,7 @@ dumpRecommendation(Database::Session session, Recommendation::IEngine& engine)
 		};
 
 		std::cout << "Processing release '" << releaseToString(releaseId) << "'" << std::endl;
-		for (Database::IdType similarReleaseId : engine.getSimilarReleases(session, {releaseId}, 3))
+		for (Database::IdType similarReleaseId : engine.getSimilarReleases(session, releaseId, 3))
 			std::cout << "\t- Similar release '" << releaseToString(similarReleaseId) << "'" << std::endl;
 	}
 
@@ -110,7 +110,7 @@ dumpRecommendation(Database::Session session, Recommendation::IEngine& engine)
 		};
 
 		std::cout << "Processing artist '" << artistToString(artistId) << "'" << std::endl;
-		for (Database::IdType similarArtistId : engine.getSimilarArtists(session, {artistId}, 3))
+		for (Database::IdType similarArtistId : engine.getSimilarArtists(session, artistId, 3))
 			std::cout << "\t- Similar artist '" << artistToString(similarArtistId) << "'" << std::endl;
 	}