Commit Graph
10 Commits
Author SHA1 Message Date
Simon Symeonidis 989bc88646 Change log.Println statement to log.Printf
This changes a statement from Println, to Printf, as it seems the
original intention was to format the error.
2025-05-17 20:04:27 -07:00
Simon Symeonidis 22755a924a Remove unused nextTrackTimer due to lint
It seems that this field is not used elsewhere in the project:

        $ ag nextTrackTimer
        backend/player/jukebox/jukeboxplayer.go
        30:     nextTrackTimer     *time.Timer
2025-05-17 21:56:15 -04:00
Simon Symeonidis 4a4596f144 Remove unused handleNextTrack method due to lint
I didn't see any other usages of this method:
        $ ag handleNextTrack
        backend/player/jukebox/jukeboxplayer.go
        158:func (j *JukeboxPlayer) handleNextTrack() {
2025-05-17 21:56:15 -04:00
Simon Symeonidis 40fb289c46 Remove unused aspect field due to lint 2025-05-17 21:56:15 -04:00
Simon Symeonidis 4855eaa6a1 Remove unused imagePopUpLowRezDim constant due to lint
Checking to see if this is used anywhere in the project, we see that it
is not:

        $ ag imagePopUpLowRezDim
        ui/widgets/imagepopup.go
        13:     imagePopUpLowRezDim = 128
2025-05-17 21:56:15 -04:00
Simon Symeonidis 5d9fea19d4 Remove unused unimplemented error due to lint
A quick check shows that this is not used anywhere else in the codebase.

        $ ag unimplemented
        backend/player/dlna/dlnaplayer.go
        34:var unimplemented = errors.New("unimplemented")
2025-05-17 21:56:15 -04:00
Simon Symeonidis d75dfb08ee Remove doSetNewTrackOrder due to unused lint
Remove doSetNewTrackOrder from ui/browsing/nowplayingpage.go: it seems
there is a same named method that is used elsewhere, instead of the one
we are removing.

        $ ag doSetNewTrackOrder
        ui/browsing/playlistpage.go
        95:     a.tracklist.OnReorderTracks = a.doSetNewTrackOrder
        210:func (a *PlaylistPage) doSetNewTrackOrder(ids []string, newPos int) {

        ui/browsing/nowplayingpage.go
        509:func (a *NowPlayingPage) doSetNewTrackOrder(idxs []int, insertPos int) {
2025-05-17 21:56:15 -04:00
Simon Symeonidis b7a7adc8b5 Add golangci-lint github action 2025-05-17 21:56:15 -04:00
Simon Symeonidis 2690b87c14 Add lint recipe in makefile 2025-05-17 21:56:14 -04:00
Simon Symeonidis 847ac4bc11 Add golangci-lint configuration file 2025-05-17 21:56:14 -04:00